Re: [PATCH 4/4] pwm: add ChromeOS EC PWM driver

2016-05-31 Thread Brian Norris
Hi Gwendal, Thanks for the review. On Sat, May 28, 2016 at 10:02:33PM -0700, Gwendal Grignou wrote: > On Fri, May 27, 2016 at 6:39 PM, Brian Norris > wrote: > > Use the new ChromeOS EC EC_CMD_PWM_{GET,SET}_DUTY commands to control > > one or more PWMs attached to the Embedded Controller. Becaus

Re: [PATCH 4/4] pwm: add ChromeOS EC PWM driver

2016-05-28 Thread Gwendal Grignou
On Fri, May 27, 2016 at 6:39 PM, Brian Norris wrote: > Use the new ChromeOS EC EC_CMD_PWM_{GET,SET}_DUTY commands to control > one or more PWMs attached to the Embedded Controller. Because the EC > allows us to modify the duty cycle (as a percentage, where U16_MAX is > 100%) but not the period, we

[PATCH 4/4] pwm: add ChromeOS EC PWM driver

2016-05-27 Thread Brian Norris
Use the new ChromeOS EC EC_CMD_PWM_{GET,SET}_DUTY commands to control one or more PWMs attached to the Embedded Controller. Because the EC allows us to modify the duty cycle (as a percentage, where U16_MAX is 100%) but not the period, we assign the period a fixed value of EC_PWM_MAX_DUTY and reject