Re: [PATCH 4/4] radeonfb: use PCI device Id in hex for name string

On Tue, Sep 04, 2007 at 03:48:07PM +0200, Benjamin Herrenschmidt wrote: > Well... ATI used to have printable characters and those were commonly > used to identify the cards. I'm not sure we want to unilateraly switch > to hex here... I see. How about the following patch? As an illustration this gi

Re: [PATCH 4/4] radeonfb: use PCI device Id in hex for name string

On Tue, 2007-09-04 at 13:00 +0200, [EMAIL PROTECTED] wrote: > .. instead of potentially using nonprintable characters. > > I guess the former (odd) concatenation was used to construct name strings > that match the "*_ATI_RADEON_??" macros in include/linux/pci_ids.h > > The PCI Id in hex is much

[PATCH 4/4] radeonfb: use PCI device Id in hex for name string

.. instead of potentially using nonprintable characters. I guess the former (odd) concatenation was used to construct name strings that match the "*_ATI_RADEON_??" macros in include/linux/pci_ids.h The PCI Id in hex is much more convenient to use. E.g. it can easily be verified against "lspci -n