Re: [PATCH 4/4] regmap: sdw: add support for SoundWire 1.2 MBQ

2020-08-28 Thread Pierre-Louis Bossart
+#include Curious why do you need this header? I'll return the question back to you, since you added this header for regmap-sdw.c: 7c22ce6e21840 (Vinod Koul 2018-01-08 15:50:59 +0530 6) #include Looks like it should be removed :) I could compile it without any issues on

Re: [PATCH 4/4] regmap: sdw: add support for SoundWire 1.2 MBQ

2020-08-28 Thread Vinod Koul
On 26-08-20, 11:57, Pierre-Louis Bossart wrote: > > > > +#include > > > +#include > > > +#include > > > > Curious why do you need this header? > > I'll return the question back to you, since you added this header for > regmap-sdw.c: > > 7c22ce6e21840 (Vinod Koul 2018-01-08

Re: [PATCH 4/4] regmap: sdw: add support for SoundWire 1.2 MBQ

2020-08-26 Thread Pierre-Louis Bossart
+#include +#include +#include Curious why do you need this header? I'll return the question back to you, since you added this header for regmap-sdw.c: 7c22ce6e21840 (Vinod Koul 2018-01-08 15:50:59 +0530 6) #include so I assumed it was needed here as well.

Re: [PATCH 4/4] regmap: sdw: add support for SoundWire 1.2 MBQ

2020-08-26 Thread Pierre-Louis Bossart
One possible objection is that this code could have been handled with regmap-sdw.c. However this is a new spec addition not handled by every SoundWire 1.1 and non-SDCA device, so there's no reason to load code that will never be used. Also in practice it's extremely unlikely that

Re: [PATCH 4/4] regmap: sdw: add support for SoundWire 1.2 MBQ

2020-08-26 Thread Mark Brown
On Tue, Aug 25, 2020 at 12:16:56PM -0500, Pierre-Louis Bossart wrote: > One possible objection is that this code could have been handled with > regmap-sdw.c. However this is a new spec addition not handled by every > SoundWire 1.1 and non-SDCA device, so there's no reason to load code > that will

Re: [PATCH 4/4] regmap: sdw: add support for SoundWire 1.2 MBQ

2020-08-26 Thread Vinod Koul
On 25-08-20, 12:16, Pierre-Louis Bossart wrote: > The SoundWire 1.1 specification only allowed for reads and writes of > bytes. The SoundWire 1.2 specification adds a new capability to > transfer "Multi-Byte Quantities" (MBQ) across the bus. The transfers > still happens one-byte-at-a-time, but

Re: [PATCH 4/4] regmap: sdw: add support for SoundWire 1.2 MBQ

2020-08-25 Thread Bard liao
On 8/26/2020 1:16 AM, Pierre-Louis Bossart wrote: The SoundWire 1.1 specification only allowed for reads and writes of bytes. The SoundWire 1.2 specification adds a new capability to transfer "Multi-Byte Quantities" (MBQ) across the bus. The transfers still happens one-byte-at-a-time, but the

[PATCH 4/4] regmap: sdw: add support for SoundWire 1.2 MBQ

2020-08-25 Thread Pierre-Louis Bossart
The SoundWire 1.1 specification only allowed for reads and writes of bytes. The SoundWire 1.2 specification adds a new capability to transfer "Multi-Byte Quantities" (MBQ) across the bus. The transfers still happens one-byte-at-a-time, but the update is atomic. For example when writing a 16-bit