Re: [PATCH 4/4] regulator: Add ROHM BD9571MWV-M PMIC regulator driver

2017-04-18 Thread Marek Vasut
On 04/18/2017 07:57 PM, Mark Brown wrote: > On Sun, Apr 16, 2017 at 08:08:01PM +0200, Marek Vasut wrote: > > This looks good, a couple of minor things though: > >> +static int bd9571mwv_regulator_is_enabled(struct regulator_dev *reg) >> +{ >> +/* Always enabled. */ >> +return 1; >> +} >

Re: [PATCH 4/4] regulator: Add ROHM BD9571MWV-M PMIC regulator driver

2017-04-18 Thread Mark Brown
On Sun, Apr 16, 2017 at 08:08:01PM +0200, Marek Vasut wrote: This looks good, a couple of minor things though: > +static int bd9571mwv_regulator_is_enabled(struct regulator_dev *reg) > +{ > + /* Always enabled. */ > + return 1; > +} This should be the default implementation, no need to o

[PATCH 4/4] regulator: Add ROHM BD9571MWV-M PMIC regulator driver

2017-04-16 Thread Marek Vasut
Add driver for the regulator block in the ROHM BD9571MWV-W MFD PMIC. This block supports three voltage monitors, VD18, VD25, VD33 for the 1V8, 2V5, 3V3 voltage rails and a single voltage regulator for the DVFS rail. Signed-off-by: Marek Vasut Cc: linux-kernel@vger.kernel.org Cc: Liam Girdwood Cc