Re: [PATCH 4/4] sched,time: only call account_{user,sys,guest,idle}_time once a jiffy

2016-02-09 Thread Rik van Riel
On Tue, 2016-02-09 at 18:11 +0100, Frederic Weisbecker wrote: >  > So for any T_slice being a given cpu timeslice (in secs) executed > between > two ring switch (user <-> kernel), we are going to account: 1 * > P(T_slice*HZ) > (P() stand for probability here). > > Now after this patch, the scenari

Re: [PATCH 4/4] sched,time: only call account_{user,sys,guest,idle}_time once a jiffy

2016-02-09 Thread Rik van Riel
On Tue, 2016-02-09 at 18:11 +0100, Frederic Weisbecker wrote: > On Tue, Feb 02, 2016 at 12:19:46PM -0500, r...@redhat.com wrote: > > From: Rik van Riel > > > > After removing __acct_update_integrals from the profile, > > native_sched_clock remains as the top CPU user. This can be > > reduced by o

Re: [PATCH 4/4] sched,time: only call account_{user,sys,guest,idle}_time once a jiffy

2016-02-09 Thread Frederic Weisbecker
On Tue, Feb 02, 2016 at 12:19:46PM -0500, r...@redhat.com wrote: > From: Rik van Riel > > After removing __acct_update_integrals from the profile, > native_sched_clock remains as the top CPU user. This can be > reduced by only calling account_{user,sys,guest,idle}_time > once per jiffy for long r

[PATCH 4/4] sched,time: only call account_{user,sys,guest,idle}_time once a jiffy

2016-02-02 Thread riel
From: Rik van Riel After removing __acct_update_integrals from the profile, native_sched_clock remains as the top CPU user. This can be reduced by only calling account_{user,sys,guest,idle}_time once per jiffy for long running tasks on nohz_full CPUs. This will reduce timing accuracy on nohz_ful

Re: [PATCH 4/4] sched,time: only call account_{user,sys,guest,idle}_time once a jiffy

2016-02-01 Thread Rik van Riel
On 02/01/2016 03:00 PM, Eric Dumazet wrote: > On Mon, 2016-02-01 at 14:21 -0500, r...@redhat.com wrote: >> From: Rik van Riel >> > >> #ifdef CONFIG_VIRT_CPU_ACCOUNTING_GEN >> +static bool vtime_jiffies_changed(struct task_struct *tsk, unsigned long >> now) >> +{ >> +if (tsk->vtime_jiffies =

Re: [PATCH 4/4] sched,time: only call account_{user,sys,guest,idle}_time once a jiffy

2016-02-01 Thread Eric Dumazet
On Mon, 2016-02-01 at 14:21 -0500, r...@redhat.com wrote: > From: Rik van Riel > > #ifdef CONFIG_VIRT_CPU_ACCOUNTING_GEN > +static bool vtime_jiffies_changed(struct task_struct *tsk, unsigned long now) > +{ > + if (tsk->vtime_jiffies == jiffies) > + return false; > + > + tsk

Re: [PATCH 4/4] sched,time: only call account_{user,sys,guest,idle}_time once a jiffy

2016-02-01 Thread Rik van Riel
On 02/01/2016 04:29 AM, Peter Zijlstra wrote: > On Sun, Jan 31, 2016 at 09:12:31PM -0500, r...@redhat.com wrote: >> Run times for the microbenchmark: >> >> 4.4 3.8 seconds >> 4.5-rc1 3.7 seconds >> 4.5-rc1 + first patch3.3 second

[PATCH 4/4] sched,time: only call account_{user,sys,guest,idle}_time once a jiffy

2016-02-01 Thread riel
From: Rik van Riel After removing __acct_update_integrals from the profile, native_sched_clock remains as the top CPU user. This can be reduced by only calling account_{user,sys,guest,idle}_time once per jiffy for long running tasks on nohz_full CPUs. This will reduce timing accuracy on nohz_ful

Re: [PATCH 4/4] sched,time: only call account_{user,sys,guest,idle}_time once a jiffy

2016-02-01 Thread Peter Zijlstra
On Sun, Jan 31, 2016 at 09:12:31PM -0500, r...@redhat.com wrote: > Run times for the microbenchmark: > > 4.4 3.8 seconds > 4.5-rc1 3.7 seconds > 4.5-rc1 + first patch 3.3 seconds > 4.5-rc1 + first 3 patches 3.1 seconds > 4.5-rc1 +

[PATCH 4/4] sched,time: only call account_{user,sys,guest,idle}_time once a jiffy

2016-01-31 Thread riel
From: Rik van Riel After removing __acct_update_integrals from the profile, native_sched_clock remains as the top CPU user. This can be reduced by only calling account_{user,sys,guest,idle}_time once per jiffy for long running tasks on nohz_full CPUs. This will reduce timing accuracy on nohz_ful

[PATCH 4/4] sched,time: only call account_{user,sys,guest,idle}_time once a jiffy

2016-01-29 Thread riel
From: Rik van Riel After removing __acct_update_integrals from the profile, native_sched_clock remains as the top CPU user. This can be reduced by only calling account_{user,sys,guest,idle}_time once per jiffy for long running tasks on nohz_full CPUs. This will reduce timing accuracy on nohz_ful