Re: [PATCH 4/4] scripts/cvt_style.pl: Tool to reformat sources in various ways

2019-10-10 Thread Joe Perches
On Thu, 2019-10-10 at 13:39 -0700, Kees Cook wrote: > On Sat, Oct 05, 2019 at 11:35:42PM -0700, Joe Perches wrote: [] > > I think clang-format could not do this sort of conversion. > > Nor could coccinelle or checkpatch. > > > > Anyway, it's not really necessary for this particular patch > > to

Re: [PATCH 4/4] scripts/cvt_style.pl: Tool to reformat sources in various ways

2019-10-10 Thread Kees Cook
On Sat, Oct 05, 2019 at 11:35:42PM -0700, Joe Perches wrote: > On Sat, 2019-10-05 at 19:31 +0200, Miguel Ojeda wrote: > > Hi Joe, > > Hello. > > > On Sat, Oct 5, 2019 at 6:47 PM Joe Perches wrote: > [] > > > As for the commit itself: while I am sure this tool is very useful > > (and certainly

Re: [PATCH 4/4] scripts/cvt_style.pl: Tool to reformat sources in various ways

2019-10-09 Thread Nick Desaulniers
On Sat, Oct 5, 2019 at 9:47 AM Joe Perches wrote: > > Trivial tool to reformat source code in various ways. > > This is an old tool that was recently updated to convert /* fallthrough */ > style comments to the new pseudo-keyword fallthrough; > > Typical command line use is: > $ perl

Re: [PATCH 4/4] scripts/cvt_style.pl: Tool to reformat sources in various ways

2019-10-06 Thread Joe Perches
On Sat, 2019-10-05 at 19:31 +0200, Miguel Ojeda wrote: > Hi Joe, Hello. > On Sat, Oct 5, 2019 at 6:47 PM Joe Perches wrote: [] > > As for the commit itself: while I am sure this tool is very useful > (and certainly you put a *lot* of effort into this tool), I don't see > how it is related to

Re: [PATCH 4/4] scripts/cvt_style.pl: Tool to reformat sources in various ways

2019-10-05 Thread Miguel Ojeda
Hi Joe, On Sat, Oct 5, 2019 at 6:47 PM Joe Perches wrote: > > diff --git a/scripts/cvt_style.pl b/scripts/cvt_style.pl > new file mode 100755 > index ..fcbda0b1c67a > --- /dev/null > +++ b/scripts/cvt_style.pl > @@ -0,0 +1,808 @@ > +#!/usr/bin/perl -w Nit: #!/usr/bin/env perl

[PATCH 4/4] scripts/cvt_style.pl: Tool to reformat sources in various ways

2019-10-05 Thread Joe Perches
Trivial tool to reformat source code in various ways. This is an old tool that was recently updated to convert /* fallthrough */ style comments to the new pseudo-keyword fallthrough; Typical command line use is: $ perl scripts/cvt_style --convert=fallthrough Available conversions: