Re: [PATCH 4/4] selftests/seccomp: Test thread vs process killing

2017-08-07 Thread Kees Cook
On Mon, Aug 7, 2017 at 6:29 PM, Tyler Hicks wrote: >> + /* Only the thread died. Let parent know this thread didn't die. */ > > This read a little odd to me. How about, "Only the created thread died. > Let parent know the this creating thread didn't die."? Sounds good.

Re: [PATCH 4/4] selftests/seccomp: Test thread vs process killing

2017-08-07 Thread Kees Cook
On Mon, Aug 7, 2017 at 6:29 PM, Tyler Hicks wrote: >> + /* Only the thread died. Let parent know this thread didn't die. */ > > This read a little odd to me. How about, "Only the created thread died. > Let parent know the this creating thread didn't die."? Sounds good. I've updated this to

Re: [PATCH 4/4] selftests/seccomp: Test thread vs process killing

2017-08-07 Thread Tyler Hicks
On 08/02/2017 10:19 PM, Kees Cook wrote: > SECCOMP_RET_KILL is supposed to kill the current thread (and userspace > depends on this), so test for this, distinct from killing the entire > process. This also tests killing the entire process with the new > SECCOMP_FILTER_FLAG_KILL_PROCESS flag. (This

Re: [PATCH 4/4] selftests/seccomp: Test thread vs process killing

2017-08-07 Thread Tyler Hicks
On 08/02/2017 10:19 PM, Kees Cook wrote: > SECCOMP_RET_KILL is supposed to kill the current thread (and userspace > depends on this), so test for this, distinct from killing the entire > process. This also tests killing the entire process with the new > SECCOMP_FILTER_FLAG_KILL_PROCESS flag. (This

[PATCH 4/4] selftests/seccomp: Test thread vs process killing

2017-08-02 Thread Kees Cook
SECCOMP_RET_KILL is supposed to kill the current thread (and userspace depends on this), so test for this, distinct from killing the entire process. This also tests killing the entire process with the new SECCOMP_FILTER_FLAG_KILL_PROCESS flag. (This also moves a bunch of defines up earlier in the

[PATCH 4/4] selftests/seccomp: Test thread vs process killing

2017-08-02 Thread Kees Cook
SECCOMP_RET_KILL is supposed to kill the current thread (and userspace depends on this), so test for this, distinct from killing the entire process. This also tests killing the entire process with the new SECCOMP_FILTER_FLAG_KILL_PROCESS flag. (This also moves a bunch of defines up earlier in the