Re: [RESEND PATCH 4/4] sh: remove board_time_init() callback

2018-07-24 Thread Baolin Wang
Hi Arnd, On 25 July 2018 at 05:33, Arnd Bergmann wrote: > On Tue, Jul 24, 2018 at 7:07 PM, kbuild test robot wrote: >> Hi Arnd, >> >> I love your patch! Yet something to improve: >> >> [auto build test ERROR on sof-driver-fuweitax/master] >> [also build test ERROR on v4.18-rc6 next-20180724] >>

Re: [RESEND PATCH 4/4] sh: remove board_time_init() callback

2018-07-24 Thread Arnd Bergmann
On Tue, Jul 24, 2018 at 7:07 PM, kbuild test robot wrote: > Hi Arnd, > > I love your patch! Yet something to improve: > > [auto build test ERROR on sof-driver-fuweitax/master] > [also build test ERROR on v4.18-rc6 next-20180724] > [if your patch is applied to the wrong git tree, please drop us a n

Re: [RESEND PATCH 4/4] sh: remove board_time_init() callback

2018-07-24 Thread kbuild test robot
Hi Arnd, I love your patch! Yet something to improve: [auto build test ERROR on sof-driver-fuweitax/master] [also build test ERROR on v4.18-rc6 next-20180724] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/l

[RESEND PATCH 4/4] sh: remove board_time_init() callback

2018-07-17 Thread Baolin Wang
From: Arnd Bergmann The only remaining user of board_time_init() is the of-generic machine, and that just calls the global timer_init() function. Calling that one has no effect on non-DT platforms, so we can simply call it unconditionally in place of board_time_init(). Signed-off-by: Arnd Bergma

Re: [PATCH 4/4] sh: remove board_time_init() callback

2018-04-21 Thread kbuild test robot
Hi Arnd, I love your patch! Yet something to improve: [auto build test ERROR on linus/master] [also build test ERROR on v4.17-rc1 next-20180420] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits/A

Re: [PATCH 4/4] sh: remove board_time_init() callback

2018-04-20 Thread Rich Felker
On Fri, Apr 20, 2018 at 11:51:18PM +0200, Arnd Bergmann wrote: > On Fri, Apr 20, 2018 at 5:48 PM, Arnd Bergmann wrote: > > > @@ -41,8 +39,7 @@ static void __init sh_late_time_init(void) > > > > void __init time_init(void) > > { > > - if (board_time_init) > > - board_time_ini

Re: [PATCH 4/4] sh: remove board_time_init() callback

2018-04-20 Thread Arnd Bergmann
On Fri, Apr 20, 2018 at 5:48 PM, Arnd Bergmann wrote: > @@ -41,8 +39,7 @@ static void __init sh_late_time_init(void) > > void __init time_init(void) > { > - if (board_time_init) > - board_time_init(); > + timer_init(); Testing revealed this to be broken, the fix is:

[PATCH 4/4] sh: remove board_time_init() callback

2018-04-20 Thread Arnd Bergmann
The only remaining user of board_time_init() is the of-generic machine, and that just calls the global timer_init() function. Calling that one has no effect on non-DT platforms, so we can simply call it unconditionally in place of board_time_init(). Signed-off-by: Arnd Bergmann --- Documentation