Re: [PATCH 4/4] soc/fsl/qe: qe.c: support fsl,qe-snums property

2019-03-01 Thread Rasmus Villemoes
> ; Rasmus Villemoes >> Subject: Re: [PATCH 4/4] soc/fsl/qe: qe.c: support fsl,qe-snums property >> >> On 01/03/2019 04.36, Qiang Zhao wrote: >>> On 2019年2月28日 18:31，Rasmus Villemoes wrote: >>> >>>> -Original Message- >>>> From: Rasm

RE: [PATCH 4/4] soc/fsl/qe: qe.c: support fsl,qe-snums property

2019-03-01 Thread Qiang Zhao
gt; >> Cc: Scott Wood ; linux-kernel@vger.kernel.org; > >> Timur Tabi ; Rasmus Villemoes > >> > >> Subject: [PATCH 4/4] soc/fsl/qe: qe.c: support fsl,qe-snums property > >> > > > > So you define 14 snums for MPC8309, but there still be the co

Re: [PATCH 4/4] soc/fsl/qe: qe.c: support fsl,qe-snums property

2019-02-28 Thread Rasmus Villemoes
bi >> ; Rasmus Villemoes >> Subject: [PATCH 4/4] soc/fsl/qe: qe.c: support fsl,qe-snums property >> >> The current code assumes that the set of snum _values_ to populate the >> snums[] array with is a function of the _number_ of snums alone. However, >> reading tabl

RE: [PATCH 4/4] soc/fsl/qe: qe.c: support fsl,qe-snums property

2019-02-28 Thread Qiang Zhao
On 2019年2月28日 18:31，Rasmus Villemoes wrote: > -Original Message- > From: Rasmus Villemoes > Sent: 2019年2月28日 18:31 > To: Qiang Zhao ; Leo Li > Cc: Scott Wood ; linux-kernel@vger.kernel.org; Timur Tabi > ; Rasmus Villemoes > Subject: [PATCH 4/4] soc/fsl/qe: qe.c:

[PATCH 4/4] soc/fsl/qe: qe.c: support fsl,qe-snums property

2019-02-28 Thread Rasmus Villemoes
The current code assumes that the set of snum _values_ to populate the snums[] array with is a function of the _number_ of snums alone. However, reading table 4-30, and its footnotes, of the QUICC Engine Block Reference Manual shows that that is a bit too naive. As an alternative, this introduces