Re: [PATCH 4/4] watchdog: st_wdt: Add new driver for ST's LPC Watchdog

2014-10-23 Thread Arnd Bergmann
On Thursday 23 October 2014 16:18:44 Lee Jones wrote: > +config ST_WATCHDOG > + tristate "STMicroelectronics LPC Watchdog" > + depends on ARCH_STI && OF > + depends on !RTC_DRV_ST_LPC > + select WATCHDOG_CORE > + help > +Say Y here to include Watchdog timer sup

[PATCH 4/4] watchdog: st_wdt: Add new driver for ST's LPC Watchdog

2014-10-23 Thread Lee Jones
Signed-off-by: David Paris Signed-off-by: Lee Jones --- drivers/watchdog/Kconfig | 16 +++ drivers/watchdog/Makefile | 1 + drivers/watchdog/st_wdt.c | 317 ++ 3 files changed, 334 insertions(+) create mode 100644 drivers/watchdog/st_wdt.c diff -

Re: [PATCH 4/4] watchdog: st_wdt: Add new driver for ST's LPC Watchdog

2014-10-09 Thread Guenter Roeck
On Thu, Oct 09, 2014 at 08:17:40AM +0100, Lee Jones wrote: > On Wed, 08 Oct 2014, Guenter Roeck wrote: > > > On Wed, Oct 08, 2014 at 10:33:30AM +0100, Lee Jones wrote: > > > Signed-off-by: David Paris > > > Signed-off-by: Lee Jones > > > --- > > > drivers/watchdog/Kconfig | 16 +++ > > > driv

Re: [PATCH 4/4] watchdog: st_wdt: Add new driver for ST's LPC Watchdog

2014-10-09 Thread Lee Jones
On Thu, 09 Oct 2014, Mark Rutland wrote: > > + res = platform_get_resource_byname(pdev, IORESOURCE_MEM, > > "syscfg-type"); > > This wasn't mentioned in the binding. A comment mentioned "type", but > there was no explicit mention of "syscfg-type" in reg-names. Thanks Mark, I'll fixup. --

Re: [PATCH 4/4] watchdog: st_wdt: Add new driver for ST's LPC Watchdog

2014-10-09 Thread Mark Rutland
> + res = platform_get_resource_byname(pdev, IORESOURCE_MEM, > "syscfg-type"); This wasn't mentioned in the binding. A comment mentioned "type", but there was no explicit mention of "syscfg-type" in reg-names. Mark. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel"

Re: [PATCH 4/4] watchdog: st_wdt: Add new driver for ST's LPC Watchdog

2014-10-09 Thread Lee Jones
On Wed, 08 Oct 2014, Guenter Roeck wrote: > On Wed, Oct 08, 2014 at 10:33:30AM +0100, Lee Jones wrote: > > Signed-off-by: David Paris > > Signed-off-by: Lee Jones > > --- > > drivers/watchdog/Kconfig | 16 +++ > > drivers/watchdog/Makefile | 1 + > > drivers/watchdog/st_wdt.c | 317 > > +++

Re: [PATCH 4/4] watchdog: st_wdt: Add new driver for ST's LPC Watchdog

2014-10-08 Thread Guenter Roeck
On Wed, Oct 08, 2014 at 10:33:30AM +0100, Lee Jones wrote: > Signed-off-by: David Paris > Signed-off-by: Lee Jones > --- > drivers/watchdog/Kconfig | 16 +++ > drivers/watchdog/Makefile | 1 + > drivers/watchdog/st_wdt.c | 317 > ++ > 3 files chan

[PATCH 4/4] watchdog: st_wdt: Add new driver for ST's LPC Watchdog

2014-10-08 Thread Lee Jones
Signed-off-by: David Paris Signed-off-by: Lee Jones --- drivers/watchdog/Kconfig | 16 +++ drivers/watchdog/Makefile | 1 + drivers/watchdog/st_wdt.c | 317 ++ 3 files changed, 334 insertions(+) create mode 100644 drivers/watchdog/st_wdt.c diff -

Re: [PATCH 4/4] watchdog: st_wdt: Add new driver for ST's LPC Watchdog

2014-10-07 Thread Guenter Roeck
On Tue, Oct 07, 2014 at 03:36:12PM +0100, Lee Jones wrote: > Signed-off-by: David Paris > Signed-off-by: Lee Jones > --- > drivers/watchdog/Kconfig | 16 +++ > drivers/watchdog/Makefile | 1 + > drivers/watchdog/st_wdt.c | 325 > ++ > 3 files chan

[PATCH 4/4] watchdog: st_wdt: Add new driver for ST's LPC Watchdog

2014-10-07 Thread Lee Jones
Signed-off-by: David Paris Signed-off-by: Lee Jones --- drivers/watchdog/Kconfig | 16 +++ drivers/watchdog/Makefile | 1 + drivers/watchdog/st_wdt.c | 325 ++ 3 files changed, 342 insertions(+) create mode 100644 drivers/watchdog/st_wdt.c diff -

Re: [PATCH 4/4] watchdog: st_wdt: Add new driver for ST's LPC Watchdog

2014-09-22 Thread David Paris
Hi, See my below comments, David On 09/08/2014 02:32 PM, Lee Jones wrote: On Fri, 05 Sep 2014, Guenter Roeck wrote: On Thu, Sep 04, 2014 at 03:39:52PM +0100, Lee Jones wrote: Some text may be useful here. There is nothing to say about this Watchdog driver. It's as simple as they come. Sig

Re: [PATCH 4/4] watchdog: st_wdt: Add new driver for ST's LPC Watchdog

2014-09-22 Thread David Paris
Hi Lee, Come back from holidays, let me take time to read my emails and come back to this one to answer your question. Thanks, David On 09/08/2014 02:32 PM, Lee Jones wrote: On Fri, 05 Sep 2014, Guenter Roeck wrote: On Thu, Sep 04, 2014 at 03:39:52PM +0100, Lee Jones wrote: Some text may b

Re: [PATCH 4/4] watchdog: st_wdt: Add new driver for ST's LPC Watchdog

2014-09-08 Thread Lee Jones
On Mon, 08 Sep 2014, Guenter Roeck wrote: > On 09/08/2014 05:32 AM, Lee Jones wrote: > >On Fri, 05 Sep 2014, Guenter Roeck wrote: > ... > >>>+ > >>>+static struct st_wdog_syscfg stid127_syscfg = { > >>>+ .type_mask = BIT(2), > >>>+ .enable_mask= BIT(2), > >>>+}; > >>>+ > >>>+static stru

Re: [PATCH 4/4] watchdog: st_wdt: Add new driver for ST's LPC Watchdog

2014-09-08 Thread Guenter Roeck
On 09/08/2014 05:32 AM, Lee Jones wrote: On Fri, 05 Sep 2014, Guenter Roeck wrote: ... + +static struct st_wdog_syscfg stid127_syscfg = { + .type_mask = BIT(2), + .enable_mask= BIT(2), +}; + +static struct st_wdog_syscfg stih415_syscfg = { + .type_mask = BIT(6),

Re: [PATCH 4/4] watchdog: st_wdt: Add new driver for ST's LPC Watchdog

2014-09-08 Thread Lee Jones
On Fri, 05 Sep 2014, Guenter Roeck wrote: > On Thu, Sep 04, 2014 at 03:39:52PM +0100, Lee Jones wrote: > > Some text may be useful here. There is nothing to say about this Watchdog driver. It's as simple as they come. > > Signed-off-by: David Paris > > Signed-off-by: Lee Jones > > --- > > dr

Re: [STLinux Kernel] [PATCH 4/4] watchdog: st_wdt: Add new driver for ST's LPC Watchdog

2014-09-05 Thread Peter Griffin
Hi, > > +static int st_wdog_remove(struct platform_device *pdev) > > +{ > > + struct st_wdog *st_wdog = watchdog_get_drvdata(&st_wdog_dev); > > + > > + if (watchdog_active(&st_wdog_dev)) > > + st_wdog_stop(&st_wdog_dev); > > + > > + st_wdog_setup(st_wdog, WDT_DISABLE); > > + > > +

Re: [PATCH 4/4] watchdog: st_wdt: Add new driver for ST's LPC Watchdog

2014-09-05 Thread Guenter Roeck
On Thu, Sep 04, 2014 at 03:39:52PM +0100, Lee Jones wrote: Some text may be useful here. > Signed-off-by: David Paris > Signed-off-by: Lee Jones > --- > drivers/watchdog/Kconfig | 16 +++ > drivers/watchdog/Makefile | 1 + > drivers/watchdog/st_wdt.c | 314 > ++

[PATCH 4/4] watchdog: st_wdt: Add new driver for ST's LPC Watchdog

2014-09-04 Thread Lee Jones
Signed-off-by: David Paris Signed-off-by: Lee Jones --- drivers/watchdog/Kconfig | 16 +++ drivers/watchdog/Makefile | 1 + drivers/watchdog/st_wdt.c | 314 ++ 3 files changed, 331 insertions(+) create mode 100644 drivers/watchdog/st_wdt.c diff -