Re: [PATCH 4/4] x86/mce/AMD: Add comments for easier understanding

2016-02-26 Thread Aravind Gopalakrishnan
On 2/26/2016 11:44 AM, Borislav Petkov wrote: threshold_restart_bank() reprograms the MISC MSR after sanity-checking the fields supplied for that MSR. store_threshold_limit() sets the error count, store_interrupt_enable() enables/disables the interrupt and both call threshold_restart_bank() to d

Re: [PATCH 4/4] x86/mce/AMD: Add comments for easier understanding

2016-02-26 Thread Borislav Petkov
On Wed, Feb 24, 2016 at 12:26:44PM -0600, Aravind Gopalakrishnan wrote: > Hmm, we call this from mce_threshold_block_init() with set_lvt_off = 1 to > write LVT offset value to MCi_MISC. > And we call this from store_interrupt_enable() to program APIC INT TYPE- > if (tr->b->interrupt_enable)

Re: [PATCH 4/4] x86/mce/AMD: Add comments for easier understanding

2016-02-24 Thread Aravind Gopalakrishnan
On 2/23/2016 6:35 AM, Borislav Petkov wrote: On Tue, Feb 16, 2016 at 03:45:11PM -0600, Aravind Gopalakrishnan wrote: /* + * Set the error_count and interrupt_enable sysfs attributes here. + * This function gets called during the init phase and when someone + * makes changes to either of the

Re: [PATCH 4/4] x86/mce/AMD: Add comments for easier understanding

2016-02-23 Thread Borislav Petkov
On Tue, Feb 16, 2016 at 03:45:11PM -0600, Aravind Gopalakrishnan wrote: > In an attempt to help folks not very familiar with the code to > understand what the code is doing, adding a bit of helper > comments around some more important functions in the driver > to describe them. > > No functional c

[PATCH 4/4] x86/mce/AMD: Add comments for easier understanding

2016-02-16 Thread Aravind Gopalakrishnan
In an attempt to help folks not very familiar with the code to understand what the code is doing, adding a bit of helper comments around some more important functions in the driver to describe them. No functional change is introduced. Signed-off-by: Aravind Gopalakrishnan --- arch/x86/kernel/cp