Re: [PATCH 4/4] zram: make deduplication feature optional

On Tue, Mar 28, 2017 at 02:12:04PM +0900, Sergey Senozhatsky wrote: > Hello Minchan, > > On (03/28/17 11:50), Minchan Kim wrote: > [..] > > > the reason I asked was that both zram and zswap sort of trying to > > > have same optimizations - zero filled pages handling, for example. > > > zram is a

Re: [PATCH 4/4] zram: make deduplication feature optional

On Tue, Mar 28, 2017 at 02:12:04PM +0900, Sergey Senozhatsky wrote: > Hello Minchan, > > On (03/28/17 11:50), Minchan Kim wrote: > [..] > > > the reason I asked was that both zram and zswap sort of trying to > > > have same optimizations - zero filled pages handling, for example. > > > zram is a

Re: [PATCH 4/4] zram: make deduplication feature optional

Hello Minchan, On (03/28/17 11:50), Minchan Kim wrote: [..] > > the reason I asked was that both zram and zswap sort of trying to > > have same optimizations - zero filled pages handling, for example. > > zram is a bit ahead now (to the best of my knowledge), because of > > the recent 'same

Re: [PATCH 4/4] zram: make deduplication feature optional

Hello Minchan, On (03/28/17 11:50), Minchan Kim wrote: [..] > > the reason I asked was that both zram and zswap sort of trying to > > have same optimizations - zero filled pages handling, for example. > > zram is a bit ahead now (to the best of my knowledge), because of > > the recent 'same

Re: [PATCH 4/4] zram: make deduplication feature optional

Hi Sergey, On Tue, Mar 28, 2017 at 11:22:45AM +0900, Sergey Senozhatsky wrote: > Cc Seth and Dan, just in case > > > Hello Joonsoo, > > On (03/28/17 10:02), Joonsoo Kim wrote: > [..] > > > so I was thinking for a moment -- do we want to keep this > > > functionality in zram or may be it

Re: [PATCH 4/4] zram: make deduplication feature optional

Hi Sergey, On Tue, Mar 28, 2017 at 11:22:45AM +0900, Sergey Senozhatsky wrote: > Cc Seth and Dan, just in case > > > Hello Joonsoo, > > On (03/28/17 10:02), Joonsoo Kim wrote: > [..] > > > so I was thinking for a moment -- do we want to keep this > > > functionality in zram or may be it

Re: [PATCH 4/4] zram: make deduplication feature optional

Cc Seth and Dan, just in case Hello Joonsoo, On (03/28/17 10:02), Joonsoo Kim wrote: [..] > > so I was thinking for a moment -- do we want to keep this > > functionality in zram or may be it belongs to allocator (zsmalloc)? > > what do you think? just a question. > > I think that zram is more

Re: [PATCH 4/4] zram: make deduplication feature optional

Cc Seth and Dan, just in case Hello Joonsoo, On (03/28/17 10:02), Joonsoo Kim wrote: [..] > > so I was thinking for a moment -- do we want to keep this > > functionality in zram or may be it belongs to allocator (zsmalloc)? > > what do you think? just a question. > > I think that zram is more

Re: [PATCH 4/4] zram: make deduplication feature optional

On Mon, Mar 27, 2017 at 05:11:05PM +0900, Sergey Senozhatsky wrote: > On (03/23/17 12:05), Joonsoo Kim wrote: > > On Wed, Mar 22, 2017 at 09:00:59AM +0900, Minchan Kim wrote: > > > On Thu, Mar 16, 2017 at 11:46:38AM +0900, js1...@gmail.com wrote: > > > > From: Joonsoo Kim

Re: [PATCH 4/4] zram: make deduplication feature optional

On Mon, Mar 27, 2017 at 05:11:05PM +0900, Sergey Senozhatsky wrote: > On (03/23/17 12:05), Joonsoo Kim wrote: > > On Wed, Mar 22, 2017 at 09:00:59AM +0900, Minchan Kim wrote: > > > On Thu, Mar 16, 2017 at 11:46:38AM +0900, js1...@gmail.com wrote: > > > > From: Joonsoo Kim > > > > > > > > Benefit

Re: [PATCH 4/4] zram: make deduplication feature optional

On (03/23/17 12:05), Joonsoo Kim wrote: > On Wed, Mar 22, 2017 at 09:00:59AM +0900, Minchan Kim wrote: > > On Thu, Mar 16, 2017 at 11:46:38AM +0900, js1...@gmail.com wrote: > > > From: Joonsoo Kim > > > > > > Benefit of deduplication is dependent on the workload so it's

Re: [PATCH 4/4] zram: make deduplication feature optional

On (03/23/17 12:05), Joonsoo Kim wrote: > On Wed, Mar 22, 2017 at 09:00:59AM +0900, Minchan Kim wrote: > > On Thu, Mar 16, 2017 at 11:46:38AM +0900, js1...@gmail.com wrote: > > > From: Joonsoo Kim > > > > > > Benefit of deduplication is dependent on the workload so it's not > > > preferable to

Re: [PATCH 4/4] zram: make deduplication feature optional

On Wed, Mar 22, 2017 at 09:00:59AM +0900, Minchan Kim wrote: > On Thu, Mar 16, 2017 at 11:46:38AM +0900, js1...@gmail.com wrote: > > From: Joonsoo Kim > > > > Benefit of deduplication is dependent on the workload so it's not > > preferable to always enable. Therefore,

Re: [PATCH 4/4] zram: make deduplication feature optional

On Wed, Mar 22, 2017 at 09:00:59AM +0900, Minchan Kim wrote: > On Thu, Mar 16, 2017 at 11:46:38AM +0900, js1...@gmail.com wrote: > > From: Joonsoo Kim > > > > Benefit of deduplication is dependent on the workload so it's not > > preferable to always enable. Therefore, make it optional. > >

Re: [PATCH 4/4] zram: make deduplication feature optional

On Thu, Mar 16, 2017 at 11:46:38AM +0900, js1...@gmail.com wrote: > From: Joonsoo Kim > > Benefit of deduplication is dependent on the workload so it's not > preferable to always enable. Therefore, make it optional. Please make it to Kconfig, too. And write down the

Re: [PATCH 4/4] zram: make deduplication feature optional

On Thu, Mar 16, 2017 at 11:46:38AM +0900, js1...@gmail.com wrote: > From: Joonsoo Kim > > Benefit of deduplication is dependent on the workload so it's not > preferable to always enable. Therefore, make it optional. Please make it to Kconfig, too. And write down the description to impress "help

[PATCH 4/4] zram: make deduplication feature optional

From: Joonsoo Kim Benefit of deduplication is dependent on the workload so it's not preferable to always enable. Therefore, make it optional. Signed-off-by: Joonsoo Kim --- drivers/block/zram/zram_drv.c | 80

[PATCH 4/4] zram: make deduplication feature optional

From: Joonsoo Kim Benefit of deduplication is dependent on the workload so it's not preferable to always enable. Therefore, make it optional. Signed-off-by: Joonsoo Kim --- drivers/block/zram/zram_drv.c | 80 ++- drivers/block/zram/zram_drv.h | 1 + 2