Re: [PATCH 4/5] DMA: sun6i: Add driver for the Allwinner A31 DMA controller

2014-02-28 Thread Maxime Ripard
On Fri, Feb 28, 2014 at 03:33:11PM +0200, Andy Shevchenko wrote: > On Fri, 2014-02-28 at 11:36 +0100, Maxime Ripard wrote: > > Hi Andy, > > > > On Tue, Feb 25, 2014 at 01:28:15PM +0200, Andy Shevchenko wrote: > > > > +static irqreturn_t sun6i_dma_interrupt(int irq, void *dev_id) > > > > +{ > > >

Re: [PATCH 4/5] DMA: sun6i: Add driver for the Allwinner A31 DMA controller

2014-02-28 Thread Andy Shevchenko
On Fri, 2014-02-28 at 11:36 +0100, Maxime Ripard wrote: > Hi Andy, > > On Tue, Feb 25, 2014 at 01:28:15PM +0200, Andy Shevchenko wrote: > > > +static irqreturn_t sun6i_dma_interrupt(int irq, void *dev_id) > > > +{ > > > + struct sun6i_dma_dev *sdev = (struct sun6i_dma_dev *)dev_id; > > > + struct

Re: [PATCH 4/5] DMA: sun6i: Add driver for the Allwinner A31 DMA controller

2014-02-28 Thread Maxime Ripard
Hi Andy, On Tue, Feb 25, 2014 at 01:28:15PM +0200, Andy Shevchenko wrote: > > +static irqreturn_t sun6i_dma_interrupt(int irq, void *dev_id) > > +{ > > + struct sun6i_dma_dev *sdev = (struct sun6i_dma_dev *)dev_id; > > + struct sun6i_vchan *vchan; > > + struct sun6i_pchan *pchan; > > +

Re: [PATCH 4/5] DMA: sun6i: Add driver for the Allwinner A31 DMA controller

2014-02-28 Thread Maxime Ripard
Hi Andy, On Tue, Feb 25, 2014 at 01:28:15PM +0200, Andy Shevchenko wrote: +static irqreturn_t sun6i_dma_interrupt(int irq, void *dev_id) +{ + struct sun6i_dma_dev *sdev = (struct sun6i_dma_dev *)dev_id; + struct sun6i_vchan *vchan; + struct sun6i_pchan *pchan; + int i, j, ret

Re: [PATCH 4/5] DMA: sun6i: Add driver for the Allwinner A31 DMA controller

2014-02-28 Thread Andy Shevchenko
On Fri, 2014-02-28 at 11:36 +0100, Maxime Ripard wrote: Hi Andy, On Tue, Feb 25, 2014 at 01:28:15PM +0200, Andy Shevchenko wrote: +static irqreturn_t sun6i_dma_interrupt(int irq, void *dev_id) +{ + struct sun6i_dma_dev *sdev = (struct sun6i_dma_dev *)dev_id; + struct sun6i_vchan

Re: [PATCH 4/5] DMA: sun6i: Add driver for the Allwinner A31 DMA controller

2014-02-28 Thread Maxime Ripard
On Fri, Feb 28, 2014 at 03:33:11PM +0200, Andy Shevchenko wrote: On Fri, 2014-02-28 at 11:36 +0100, Maxime Ripard wrote: Hi Andy, On Tue, Feb 25, 2014 at 01:28:15PM +0200, Andy Shevchenko wrote: +static irqreturn_t sun6i_dma_interrupt(int irq, void *dev_id) +{ + struct

Re: [PATCH 4/5] DMA: sun6i: Add driver for the Allwinner A31 DMA controller

2014-02-25 Thread Andy Shevchenko
On Mon, 2014-02-24 at 17:22 +0100, Maxime Ripard wrote: > The Allwinner A31 has a 16 channels DMA controller that it shares with the > newer A23. Although sharing some similarities with the DMA controller of the > older Allwinner SoCs, it's significantly different, I don't expect it to be >

Re: [PATCH 4/5] DMA: sun6i: Add driver for the Allwinner A31 DMA controller

2014-02-25 Thread Andy Shevchenko
On Mon, 2014-02-24 at 17:22 +0100, Maxime Ripard wrote: The Allwinner A31 has a 16 channels DMA controller that it shares with the newer A23. Although sharing some similarities with the DMA controller of the older Allwinner SoCs, it's significantly different, I don't expect it to be possible

[PATCH 4/5] DMA: sun6i: Add driver for the Allwinner A31 DMA controller

2014-02-24 Thread Maxime Ripard
The Allwinner A31 has a 16 channels DMA controller that it shares with the newer A23. Although sharing some similarities with the DMA controller of the older Allwinner SoCs, it's significantly different, I don't expect it to be possible to share the driver for these two. The A31 Controller is

[PATCH 4/5] DMA: sun6i: Add driver for the Allwinner A31 DMA controller

2014-02-24 Thread Maxime Ripard
The Allwinner A31 has a 16 channels DMA controller that it shares with the newer A23. Although sharing some similarities with the DMA controller of the older Allwinner SoCs, it's significantly different, I don't expect it to be possible to share the driver for these two. The A31 Controller is