Re: [PATCH 4/5] add cursor hotspot to drm_framebuffer

2016-05-31 Thread Ville Syrjälä
On Tue, May 31, 2016 at 03:09:13PM +0200, Gerd Hoffmann wrote: > On Di, 2016-05-31 at 15:36 +0300, Ville Syrjälä wrote: > > > Why store it in the fb and not eg. the plane state? > > Well, drm_plane_state is allocated by drm_atomic_helper_update_plane. > > When sticking the hotspot into the the p

Re: [PATCH 4/5] add cursor hotspot to drm_framebuffer

2016-05-31 Thread Gerd Hoffmann
On Di, 2016-05-31 at 15:36 +0300, Ville Syrjälä wrote: > Why store it in the fb and not eg. the plane state? Well, drm_plane_state is allocated by drm_atomic_helper_update_plane. When sticking the hotspot into the the plane state we have to add hot_x and hot_y parameters to drm_plane_funcs->upda

Re: [PATCH 4/5] add cursor hotspot to drm_framebuffer

2016-05-31 Thread Ville Syrjälä
On Tue, May 31, 2016 at 12:53:12PM +0200, Gerd Hoffmann wrote: > Signed-off-by: Gerd Hoffmann > --- > drivers/gpu/drm/drm_crtc.c | 2 ++ > include/drm/drm_crtc.h | 2 ++ > 2 files changed, 4 insertions(+) > > diff --git a/drivers/gpu/drm/drm_crtc.c b/drivers/gpu/drm/drm_crtc.c > index d2a6d9

Re: [PATCH 4/5] add cursor hotspot to drm_framebuffer

2016-05-31 Thread Daniel Vetter
On Tue, May 31, 2016 at 12:53:12PM +0200, Gerd Hoffmann wrote: > Signed-off-by: Gerd Hoffmann Reviewed-by: Daniel Vetter And feel free to include in a virtio pull to Dave with my ack. -Daniel > --- > drivers/gpu/drm/drm_crtc.c | 2 ++ > include/drm/drm_crtc.h | 2 ++ > 2 files changed, 4

[PATCH 4/5] add cursor hotspot to drm_framebuffer

2016-05-31 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann --- drivers/gpu/drm/drm_crtc.c | 2 ++ include/drm/drm_crtc.h | 2 ++ 2 files changed, 4 insertions(+) diff --git a/drivers/gpu/drm/drm_crtc.c b/drivers/gpu/drm/drm_crtc.c index d2a6d95..ce5a280 100644 --- a/drivers/gpu/drm/drm_crtc.c +++ b/drivers/gpu/drm/drm_cr