Re: [PATCH 4/5] atmel_serial: Split the interrupt handler

2007-12-19 Thread Haavard Skinnemoen
On Wed, 19 Dec 2007 12:40:08 +0100 Haavard Skinnemoen <[EMAIL PROTECTED]> wrote: > Btw, the funny thing is that, looking at my shell history, I think I > actually did the right thing when committing your patches: > > git commit -s --author 'Remy Bohmer <[EMAIL PROTECTED]>' > git commit -s

Re: [PATCH 4/5] atmel_serial: Split the interrupt handler

2007-12-19 Thread Haavard Skinnemoen
On Tue, 18 Dec 2007 13:19:39 -0500 (EST) Chip Coldwell <[EMAIL PROTECTED]> wrote: > > On Tue, 18 Dec 2007 18:06:14 +0100 > > Haavard Skinnemoen <[EMAIL PROTECTED]> wrote: > > > > > From: Remy Bohmer <[EMAIL PROTECTED]> > > > > Heh. That's obviously wrong. Wonder what happened there? > > >

Re: [PATCH 4/5] atmel_serial: Split the interrupt handler

2007-12-19 Thread Haavard Skinnemoen
On Wed, 19 Dec 2007 00:15:24 +0100 Jiri Slaby <[EMAIL PROTECTED]> wrote: > On 12/18/2007 06:06 PM, Haavard Skinnemoen wrote: > > port = _ports[pdev->id]; > > atmel_init_port(port, pdev); > > > > + data = kmalloc(ATMEL_SERIAL_RINGSIZE, GFP_KERNEL); > > + if (!data) > > { >

Re: [PATCH 4/5] atmel_serial: Split the interrupt handler

2007-12-19 Thread Haavard Skinnemoen
On Wed, 19 Dec 2007 00:15:24 +0100 Jiri Slaby [EMAIL PROTECTED] wrote: On 12/18/2007 06:06 PM, Haavard Skinnemoen wrote: port = atmel_ports[pdev-id]; atmel_init_port(port, pdev); + data = kmalloc(ATMEL_SERIAL_RINGSIZE, GFP_KERNEL); + if (!data) {

Re: [PATCH 4/5] atmel_serial: Split the interrupt handler

2007-12-19 Thread Haavard Skinnemoen
On Tue, 18 Dec 2007 13:19:39 -0500 (EST) Chip Coldwell [EMAIL PROTECTED] wrote: On Tue, 18 Dec 2007 18:06:14 +0100 Haavard Skinnemoen [EMAIL PROTECTED] wrote: From: Remy Bohmer [EMAIL PROTECTED] Heh. That's obviously wrong. Wonder what happened there? Looks like Chip's

Re: [PATCH 4/5] atmel_serial: Split the interrupt handler

2007-12-19 Thread Haavard Skinnemoen
On Wed, 19 Dec 2007 12:40:08 +0100 Haavard Skinnemoen [EMAIL PROTECTED] wrote: Btw, the funny thing is that, looking at my shell history, I think I actually did the right thing when committing your patches: git commit -s --author 'Remy Bohmer [EMAIL PROTECTED]' git commit -s --author 'Chip

Re: [PATCH 4/5] atmel_serial: Split the interrupt handler

2007-12-18 Thread Jiri Slaby
On 12/18/2007 06:06 PM, Haavard Skinnemoen wrote: > From: Remy Bohmer <[EMAIL PROTECTED]> > > This patch splits up the interrupt handler of the serial port > into a interrupt top-half and a tasklet. [...] > [EMAIL PROTECTED]: misc cleanups and simplifications] > Signed-off-by: Remy Bohmer <[EMAIL

Re: [PATCH 4/5] atmel_serial: Split the interrupt handler

2007-12-18 Thread Chip Coldwell
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On Tue, 18 Dec 2007, Haavard Skinnemoen wrote: > On Tue, 18 Dec 2007 18:06:14 +0100 > Haavard Skinnemoen <[EMAIL PROTECTED]> wrote: > > > From: Remy Bohmer <[EMAIL PROTECTED]> > > Heh. That's obviously wrong. Wonder what happened there? > > Looks

Re: [PATCH 4/5] atmel_serial: Split the interrupt handler

2007-12-18 Thread Haavard Skinnemoen
On Tue, 18 Dec 2007 18:06:14 +0100 Haavard Skinnemoen <[EMAIL PROTECTED]> wrote: > From: Remy Bohmer <[EMAIL PROTECTED]> Heh. That's obviously wrong. Wonder what happened there? Looks like Chip's address got mangled too. Haavard -- To unsubscribe from this list: send the line "unsubscribe

[PATCH 4/5] atmel_serial: Split the interrupt handler

2007-12-18 Thread Haavard Skinnemoen
From: Remy Bohmer <[EMAIL PROTECTED]> This patch splits up the interrupt handler of the serial port into a interrupt top-half and a tasklet. The goal is to get the interrupt top-half as short as possible to minimize latencies on interrupts. But the old code also does some calls in the interrupt

[PATCH 4/5] atmel_serial: Split the interrupt handler

2007-12-18 Thread Haavard Skinnemoen
From: Remy Bohmer [EMAIL PROTECTED] This patch splits up the interrupt handler of the serial port into a interrupt top-half and a tasklet. The goal is to get the interrupt top-half as short as possible to minimize latencies on interrupts. But the old code also does some calls in the interrupt

Re: [PATCH 4/5] atmel_serial: Split the interrupt handler

2007-12-18 Thread Haavard Skinnemoen
On Tue, 18 Dec 2007 18:06:14 +0100 Haavard Skinnemoen [EMAIL PROTECTED] wrote: From: Remy Bohmer [EMAIL PROTECTED] Heh. That's obviously wrong. Wonder what happened there? Looks like Chip's address got mangled too. Haavard -- To unsubscribe from this list: send the line unsubscribe

Re: [PATCH 4/5] atmel_serial: Split the interrupt handler

2007-12-18 Thread Chip Coldwell
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On Tue, 18 Dec 2007, Haavard Skinnemoen wrote: On Tue, 18 Dec 2007 18:06:14 +0100 Haavard Skinnemoen [EMAIL PROTECTED] wrote: From: Remy Bohmer [EMAIL PROTECTED] Heh. That's obviously wrong. Wonder what happened there? Looks like Chip's

Re: [PATCH 4/5] atmel_serial: Split the interrupt handler

2007-12-18 Thread Jiri Slaby
On 12/18/2007 06:06 PM, Haavard Skinnemoen wrote: From: Remy Bohmer [EMAIL PROTECTED] This patch splits up the interrupt handler of the serial port into a interrupt top-half and a tasklet. [...] [EMAIL PROTECTED]: misc cleanups and simplifications] Signed-off-by: Remy Bohmer [EMAIL