Re: [PATCH 4/5] clk: qcom: Add A53 clock driver

2015-06-16 Thread Paul Bolle
On Mon, 2015-06-15 at 18:36 +0300, Georgi Djakov wrote: > In general, it is not expected to unload it as this is for the > main CPU clock, but i will add a module_exit() call to make it > correct. It's not incorrect to not have a module_exit() call. But not having it means you can't (easily and cl

Re: [PATCH 4/5] clk: qcom: Add A53 clock driver

2015-06-15 Thread Georgi Djakov
On 06/15/2015 04:58 PM, Paul Bolle wrote: > On Fri, 2015-06-12 at 11:41 +0300, Georgi Djakov wrote: >> --- /dev/null >> +++ b/drivers/clk/qcom/clk-a53.c > >> +static int __init qcom_a53_init(void) >> +{ >> +return platform_driver_register(&qcom_a53_driver); >> +} >> +arch_initcall(qcom_a53_ini

Re: [PATCH 4/5] clk: qcom: Add A53 clock driver

2015-06-15 Thread Paul Bolle
On Fri, 2015-06-12 at 11:41 +0300, Georgi Djakov wrote: > --- /dev/null > +++ b/drivers/clk/qcom/clk-a53.c > +static int __init qcom_a53_init(void) > +{ > + return platform_driver_register(&qcom_a53_driver); > +} > +arch_initcall(qcom_a53_init); There's no function that's, well, called by mod

[PATCH 4/5] clk: qcom: Add A53 clock driver

2015-06-12 Thread Georgi Djakov
Add a driver for the A53 subsystem PLL, so that we can provide higher frequency clocks for use by the system. Signed-off-by: Georgi Djakov --- Documentation/devicetree/bindings/clock/qcom,a53cc | 22 +++ drivers/clk/qcom/Kconfig |8 + drivers/clk/qcom/Makefile