Re: [PATCH 4/5] clocksource: rockchip: add support for rk3399 SoC

2016-05-31 Thread Daniel Lezcano
On 06/01/2016 03:58 AM, Huang, Tao wrote: Hi Daniel: On 2016年05月31日 22:06, Daniel Lezcano wrote: [ ... ] -CLOCKSOURCE_OF_DECLARE(rk_timer, "rockchip,rk3288-timer", rk_timer_init); +static void __init rk3288_timer_init(struct device_node *np) +{ + bc_timer.ctrl = TIMER_CONTROL_REG3288; +

Re: [PATCH 4/5] clocksource: rockchip: add support for rk3399 SoC

2016-05-31 Thread Huang, Tao
Hi Daniel: On 2016年05月31日 22:06, Daniel Lezcano wrote: >> >> @@ -46,15 +48,20 @@ static inline void __iomem *rk_base(struct >> clock_event_device *ce) >> return rk_timer(ce)->base; >> } >> >> +static inline void __iomem *rk_ctrl(struct clock_event_device *ce) >> +{ >> +return rk_timer(ce

Re: [PATCH 4/5] clocksource: rockchip: add support for rk3399 SoC

2016-05-31 Thread Daniel Lezcano
On 05/31/2016 03:46 PM, Huang, Tao wrote: Hi Daniel: On 2016年05月31日 07:28, Daniel Lezcano wrote: On 05/25/2016 11:50 AM, Caesar Wang wrote: From: Huang Tao The CONTROL register offset is different from old SoCs. For Linux driver, there are not functional changes at all. Let's call it v2. Sig

Re: [PATCH 4/5] clocksource: rockchip: add support for rk3399 SoC

2016-05-31 Thread Huang, Tao
Hi Daniel: On 2016年05月31日 07:28, Daniel Lezcano wrote: > On 05/25/2016 11:50 AM, Caesar Wang wrote: >> From: Huang Tao >> >> The CONTROL register offset is different from old SoCs. >> For Linux driver, there are not functional changes at all. >> Let's call it v2. >> >> Signed-off-by: Huang Tao >>

Re: [PATCH 4/5] clocksource: rockchip: add support for rk3399 SoC

2016-05-30 Thread Daniel Lezcano
On 05/25/2016 11:50 AM, Caesar Wang wrote: From: Huang Tao The CONTROL register offset is different from old SoCs. For Linux driver, there are not functional changes at all. Let's call it v2. Signed-off-by: Huang Tao Cc: Daniel Lezcano Cc: Thomas Gleixner Cc: Heiko Stuebner Tested-by: Jian

[PATCH 4/5] clocksource: rockchip: add support for rk3399 SoC

2016-05-25 Thread Caesar Wang
From: Huang Tao The CONTROL register offset is different from old SoCs. For Linux driver, there are not functional changes at all. Let's call it v2. Signed-off-by: Huang Tao Cc: Daniel Lezcano Cc: Thomas Gleixner Cc: Heiko Stuebner Tested-by: Jianqun Xu Signed-off-by: Caesar Wang --- dri