Re: [PATCH 4/5] crypto: lib/sha256 - Unroll SHA256 loop 8 times intead of 64

2020-10-20 Thread Arvind Sankar
16:30 > > > > To: Herbert Xu ; David S. Miller > > > > ; linux- > > > > cry...@vger.kernel.org > > > > Cc: linux-kernel@vger.kernel.org > > > > Subject: [PATCH 4/5] crypto: lib/sha256 - Unroll SHA256 loop 8 times > >

RE: [PATCH 4/5] crypto: lib/sha256 - Unroll SHA256 loop 8 times intead of 64

2020-10-20 Thread David Laight
t; cry...@vger.kernel.org > > > Cc: linux-kernel@vger.kernel.org > > > Subject: [PATCH 4/5] crypto: lib/sha256 - Unroll SHA256 loop 8 times > > > intead of 64 > > > > > > This reduces code size substantially (on x86_64 with gcc-10 the size of > > &

Re: [PATCH 4/5] crypto: lib/sha256 - Unroll SHA256 loop 8 times intead of 64

2020-10-20 Thread Arvind Sankar
On Tue, Oct 20, 2020 at 07:41:33AM +, David Laight wrote: > From: Arvind Sankar> Sent: 19 October 2020 16:30 > > To: Herbert Xu ; David S. Miller > > ; linux- > > cry...@vger.kernel.org > > Cc: linux-kernel@vger.kernel.org > > Subject: [PATCH 4/5] crypt

RE: [PATCH 4/5] crypto: lib/sha256 - Unroll SHA256 loop 8 times intead of 64

2020-10-20 Thread David Laight
From: Arvind Sankar> Sent: 19 October 2020 16:30 > To: Herbert Xu ; David S. Miller > ; linux- > cry...@vger.kernel.org > Cc: linux-kernel@vger.kernel.org > Subject: [PATCH 4/5] crypto: lib/sha256 - Unroll SHA256 loop 8 times intead > of 64 > > This reduces code si

[PATCH 4/5] crypto: lib/sha256 - Unroll SHA256 loop 8 times intead of 64

2020-10-19 Thread Arvind Sankar
This reduces code size substantially (on x86_64 with gcc-10 the size of sha256_update() goes from 7593 bytes to 1952 bytes including the new SHA256_K array), and on x86 is slightly faster than the full unroll. Signed-off-by: Arvind Sankar --- lib/crypto/sha256.c | 164 ---