Re: [PATCH 4/5] drivers/video/da8xx-fb.c: use devm_ functions

2012-07-31 Thread Damien Cassou
The whole patch is incorrect because of: On Tue, Jul 31, 2012 at 5:47 PM, Sachin Kamat wrote: >> - ret = request_irq(par->irq, lcdc_irq_handler, 0, >> - DRIVER_NAME, par); >> + ret = devm_request_irq(&device->dev, par->irq, lcdc_irq_handler, 0, >> +

Re: [PATCH 4/5] drivers/video/da8xx-fb.c: use devm_ functions

2012-07-31 Thread Sachin Kamat
On 31 July 2012 19:24, Damien Cassou wrote: > From: Damien Cassou > > The various devm_ functions allocate memory that is released when a driver > detaches. This patch uses these functions for data that is allocated in > the probe function of a platform device and is only freed in the remove > f

[PATCH 4/5] drivers/video/da8xx-fb.c: use devm_ functions

2012-07-31 Thread Damien Cassou
From: Damien Cassou The various devm_ functions allocate memory that is released when a driver detaches. This patch uses these functions for data that is allocated in the probe function of a platform device and is only freed in the remove function. Signed-off-by: Damien Cassou --- drivers/vi