Re: [PATCH 4/5] dt-bindings: memory: tegra: Add missing swgroups

2020-10-27 Thread Nicolin Chen
On Tue, Oct 27, 2020 at 01:55:06PM +0100, Thierry Reding wrote: > This does indeed look correct, based on what registers exist for these. > It'd be good to know how Nicolin expects these to be used, since these > are currently not listed in device tree. There's certainly some like Judging from ou

Re: [PATCH 4/5] dt-bindings: memory: tegra: Add missing swgroups

2020-10-27 Thread Krzysztof Kozlowski
On Wed, Oct 07, 2020 at 05:37:45PM -0700, Nicolin Chen wrote: > According to Tegra X1 TRM, there are missing swgroups in the > tegra210_swgroups list. So this patch adds them in bindings. > > Note that the TEGRA_SWGROUP_GPU (in list) should be actually > TEGRA_SWGROUP_GPUB (in TRM), yet TEGRA_SWGR

Re: [PATCH 4/5] dt-bindings: memory: tegra: Add missing swgroups

2020-10-27 Thread Thierry Reding
On Mon, Oct 26, 2020 at 09:17:58PM +0100, Krzysztof Kozlowski wrote: > On Fri, Oct 09, 2020 at 08:52:18AM -0700, Nicolin Chen wrote: > > On Fri, Oct 09, 2020 at 02:21:10PM +0200, Thierry Reding wrote: > > > On Wed, Oct 07, 2020 at 05:37:45PM -0700, Nicolin Chen wrote: > > > > According to Tegra X1

Re: [PATCH 4/5] dt-bindings: memory: tegra: Add missing swgroups

2020-10-26 Thread Krzysztof Kozlowski
On Fri, Oct 09, 2020 at 08:52:18AM -0700, Nicolin Chen wrote: > On Fri, Oct 09, 2020 at 02:21:10PM +0200, Thierry Reding wrote: > > On Wed, Oct 07, 2020 at 05:37:45PM -0700, Nicolin Chen wrote: > > > According to Tegra X1 TRM, there are missing swgroups in the > > > tegra210_swgroups list. So this

Re: [PATCH 4/5] dt-bindings: memory: tegra: Add missing swgroups

2020-10-09 Thread Nicolin Chen
On Fri, Oct 09, 2020 at 02:21:10PM +0200, Thierry Reding wrote: > On Wed, Oct 07, 2020 at 05:37:45PM -0700, Nicolin Chen wrote: > > According to Tegra X1 TRM, there are missing swgroups in the > > tegra210_swgroups list. So this patch adds them in bindings. > > > > Note that the TEGRA_SWGROUP_GPU

Re: [PATCH 4/5] dt-bindings: memory: tegra: Add missing swgroups

2020-10-09 Thread Thierry Reding
On Wed, Oct 07, 2020 at 05:37:45PM -0700, Nicolin Chen wrote: > According to Tegra X1 TRM, there are missing swgroups in the > tegra210_swgroups list. So this patch adds them in bindings. > > Note that the TEGRA_SWGROUP_GPU (in list) should be actually > TEGRA_SWGROUP_GPUB (in TRM), yet TEGRA_SWGR

[PATCH 4/5] dt-bindings: memory: tegra: Add missing swgroups

2020-10-07 Thread Nicolin Chen
According to Tegra X1 TRM, there are missing swgroups in the tegra210_swgroups list. So this patch adds them in bindings. Note that the TEGRA_SWGROUP_GPU (in list) should be actually TEGRA_SWGROUP_GPUB (in TRM), yet TEGRA_SWGROUP_GPU (in TRM) is not being used -- only TEGRA_SWGROUP_GPUB (in TRM) i