Re: [PATCH 4/5] gpio: of: remove of_gpiochip_and_xlate() and struct gg_data

2016-06-23 Thread Linus Walleij
On Tue, Jun 14, 2016 at 12:07 PM, Masahiro Yamada wrote: > The usage of gpiochip_find(&gg_data, of_gpiochip_and_xlate) is odd. > > Usually gpiochip_find() is used to find a gpio_chip. Here, however, > the return value from gpiochip_find() is just discarded. Instead, > gpiochip_find(&gg_data, of

[PATCH 4/5] gpio: of: remove of_gpiochip_and_xlate() and struct gg_data

2016-06-14 Thread Masahiro Yamada
The usage of gpiochip_find(&gg_data, of_gpiochip_and_xlate) is odd. Usually gpiochip_find() is used to find a gpio_chip. Here, however, the return value from gpiochip_find() is just discarded. Instead, gpiochip_find(&gg_data, of_gpiochip_and_xlate) is called for the side-effect of the match func