Re: [PATCH 4/5] input: tc3589x-keypad: support probing from device tree

2013-11-01 Thread Linus Walleij
On Thu, Oct 31, 2013 at 5:58 PM, Mark Rutland wrote: >> + plat = devm_kzalloc(dev, sizeof(*plat), GFP_KERNEL); >> + if (!plat) >> + return ERR_PTR(-ENOMEM); >> + >> + of_property_read_u8(np, "keypad,num-columns", >kcol); >> + of_property_read_u8(np, "keypad,num-rows",

Re: [PATCH 4/5] input: tc3589x-keypad: support probing from device tree

2013-11-01 Thread Linus Walleij
On Thu, Oct 31, 2013 at 5:58 PM, Mark Rutland mark.rutl...@arm.com wrote: + plat = devm_kzalloc(dev, sizeof(*plat), GFP_KERNEL); + if (!plat) + return ERR_PTR(-ENOMEM); + + of_property_read_u8(np, keypad,num-columns, plat-kcol); + of_property_read_u8(np,

Re: [PATCH 4/5] input: tc3589x-keypad: support probing from device tree

2013-10-31 Thread Mark Rutland
On Tue, Oct 15, 2013 at 10:21:11PM +0100, Linus Walleij wrote: > Implement device tree probing for the tc3589x keypad driver. > This is modeled on the STMPE keypad driver and tested on the > Ux500 TVK1281618 UIB. > > Signed-off-by: Linus Walleij > --- > drivers/input/keyboard/tc3589x-keypad.c |

Re: [PATCH 4/5] input: tc3589x-keypad: support probing from device tree

2013-10-31 Thread Mark Rutland
On Tue, Oct 15, 2013 at 10:21:11PM +0100, Linus Walleij wrote: Implement device tree probing for the tc3589x keypad driver. This is modeled on the STMPE keypad driver and tested on the Ux500 TVK1281618 UIB. Signed-off-by: Linus Walleij linus.wall...@linaro.org ---

Re: [PATCH 4/5] input: tc3589x-keypad: support probing from device tree

2013-10-16 Thread Linus Walleij
On Wed, Oct 16, 2013 at 8:39 AM, Dmitry Torokhov wrote: > On Tue, Oct 15, 2013 at 11:21:11PM +0200, Linus Walleij wrote: >> Implement device tree probing for the tc3589x keypad driver. >> This is modeled on the STMPE keypad driver and tested on the >> Ux500 TVK1281618 UIB. >> >> Signed-off-by:

Re: [PATCH 4/5] input: tc3589x-keypad: support probing from device tree

2013-10-16 Thread Dmitry Torokhov
On Tue, Oct 15, 2013 at 11:21:11PM +0200, Linus Walleij wrote: > Implement device tree probing for the tc3589x keypad driver. > This is modeled on the STMPE keypad driver and tested on the > Ux500 TVK1281618 UIB. > > Signed-off-by: Linus Walleij Looks good, should I merge it or you want to take

Re: [PATCH 4/5] input: tc3589x-keypad: support probing from device tree

2013-10-16 Thread Dmitry Torokhov
On Tue, Oct 15, 2013 at 11:21:11PM +0200, Linus Walleij wrote: Implement device tree probing for the tc3589x keypad driver. This is modeled on the STMPE keypad driver and tested on the Ux500 TVK1281618 UIB. Signed-off-by: Linus Walleij linus.wall...@linaro.org Looks good, should I merge it

Re: [PATCH 4/5] input: tc3589x-keypad: support probing from device tree

2013-10-16 Thread Linus Walleij
On Wed, Oct 16, 2013 at 8:39 AM, Dmitry Torokhov dmitry.torok...@gmail.com wrote: On Tue, Oct 15, 2013 at 11:21:11PM +0200, Linus Walleij wrote: Implement device tree probing for the tc3589x keypad driver. This is modeled on the STMPE keypad driver and tested on the Ux500 TVK1281618 UIB.

[PATCH 4/5] input: tc3589x-keypad: support probing from device tree

2013-10-15 Thread Linus Walleij
Implement device tree probing for the tc3589x keypad driver. This is modeled on the STMPE keypad driver and tested on the Ux500 TVK1281618 UIB. Signed-off-by: Linus Walleij --- drivers/input/keyboard/tc3589x-keypad.c | 63 +++-- 1 file changed, 61 insertions(+), 2

[PATCH 4/5] input: tc3589x-keypad: support probing from device tree

2013-10-15 Thread Linus Walleij
Implement device tree probing for the tc3589x keypad driver. This is modeled on the STMPE keypad driver and tested on the Ux500 TVK1281618 UIB. Signed-off-by: Linus Walleij linus.wall...@linaro.org --- drivers/input/keyboard/tc3589x-keypad.c | 63 +++-- 1 file