Re: [PATCH 4/5] lib/ioremap: Ensure phys_addr actually corresponds to a physical address

2018-09-12 Thread Sean Christopherson
On Wed, Sep 12, 2018 at 05:39:14PM +0100, Will Deacon wrote: > Hi Sean, > > Thanks for looking at the patch. > > On Wed, Sep 12, 2018 at 08:09:39AM -0700, Sean Christopherson wrote: > > On Wed, Sep 12, 2018 at 11:26:13AM +0100, Will Deacon wrote: > > > The current ioremap() code uses a phys_addr

Re: [PATCH 4/5] lib/ioremap: Ensure phys_addr actually corresponds to a physical address

2018-09-12 Thread Will Deacon
Hi Sean, Thanks for looking at the patch. On Wed, Sep 12, 2018 at 08:09:39AM -0700, Sean Christopherson wrote: > On Wed, Sep 12, 2018 at 11:26:13AM +0100, Will Deacon wrote: > > The current ioremap() code uses a phys_addr variable at each level of > > page table, which is confusingly offset by su

Re: [PATCH 4/5] lib/ioremap: Ensure phys_addr actually corresponds to a physical address

2018-09-12 Thread Sean Christopherson
On Wed, Sep 12, 2018 at 11:26:13AM +0100, Will Deacon wrote: > The current ioremap() code uses a phys_addr variable at each level of > page table, which is confusingly offset by subtracting the base virtual > address being mapped so that adding the current virtual address back on > when iterating t

[PATCH 4/5] lib/ioremap: Ensure phys_addr actually corresponds to a physical address

2018-09-12 Thread Will Deacon
The current ioremap() code uses a phys_addr variable at each level of page table, which is confusingly offset by subtracting the base virtual address being mapped so that adding the current virtual address back on when iterating through the page table entries gives back the corresponding physical a