Re: [PATCH 4/5] mtd: spi-nor: Add driver for Adaptrum Anarion QSPI controller

2017-07-31 Thread Alexandru Gagniuc
On 07/31/2017 03:43 PM, Marek Vasut wrote: On 08/01/2017 12:20 AM, Alexandru Gagniuc wrote: On 07/31/2017 02:33 PM, Marek Vasut wrote: On 07/31/2017 07:17 PM, Alexandru Gagniuc wrote: +struct anarion_qspi { +structspi_nor nor; +structdevice *dev; +uintptr_tregba

Re: [PATCH 4/5] mtd: spi-nor: Add driver for Adaptrum Anarion QSPI controller

2017-07-31 Thread Marek Vasut
On 08/01/2017 12:20 AM, Alexandru Gagniuc wrote: > On 07/31/2017 02:33 PM, Marek Vasut wrote: >> On 07/31/2017 07:17 PM, Alexandru Gagniuc wrote: > > Hi Marek, > > Thank you again for your feedback. I've applied a majority of your > suggestions, and I am very happy with the result. I should have

Re: [PATCH 4/5] mtd: spi-nor: Add driver for Adaptrum Anarion QSPI controller

2017-07-31 Thread Alexandru Gagniuc
On 07/31/2017 02:33 PM, Marek Vasut wrote: On 07/31/2017 07:17 PM, Alexandru Gagniuc wrote: Hi Marek, Thank you again for your feedback. I've applied a majority of your suggestions, and I am very happy with the result. I should have v2 posted within a day or so. [snip] +/* + * This mask d

Re: [PATCH 4/5] mtd: spi-nor: Add driver for Adaptrum Anarion QSPI controller

2017-07-31 Thread Marek Vasut
On 07/31/2017 07:17 PM, Alexandru Gagniuc wrote: [...] >>> +++ b/drivers/mtd/spi-nor/anarion-quadspi.c >>> @@ -0,0 +1,490 @@ >>> +/* >>> + * Adaptrum Anarion Quad SPI controller driver >>> + * >>> + * Copyright (C) 2017, Adaptrum, Inc. >>> + * (Written by Alexandru Gagniuc for >>> Adaptrum, Inc.)

Re: [PATCH 4/5] mtd: spi-nor: Add driver for Adaptrum Anarion QSPI controller

2017-07-31 Thread Marek Vasut
On 07/31/2017 10:54 PM, Alexandru Gagniuc wrote: > Hi Marek, > > Me again! > > On 07/29/2017 02:34 AM, Marek Vasut wrote: >> On 07/29/2017 12:07 AM, Alexandru Gagniuc wrote: >>> +static void aspi_drain_fifo(struct anarion_qspi *aspi, uint8_t *buf, >>> size_t len) >>> +{ >>> +uint32_t data; >>

Re: [PATCH 4/5] mtd: spi-nor: Add driver for Adaptrum Anarion QSPI controller

2017-07-31 Thread Alexandru Gagniuc
Hi Marek, Me again! On 07/29/2017 02:34 AM, Marek Vasut wrote: On 07/29/2017 12:07 AM, Alexandru Gagniuc wrote: +static void aspi_drain_fifo(struct anarion_qspi *aspi, uint8_t *buf, size_t len) +{ + uint32_t data; Is this stuff below something like ioread32_rep() ? [snip] + a

Re: [PATCH 4/5] mtd: spi-nor: Add driver for Adaptrum Anarion QSPI controller

2017-07-31 Thread Alexandru Gagniuc
On 07/29/2017 02:34 AM, Marek Vasut wrote: On 07/29/2017 12:07 AM, Alexandru Gagniuc wrote: Add support for the QSPI controller found in Adaptrum Anarion SOCs. This controller is designed specifically to handle SPI NOR chips, and the driver is modeled as such. Because the system is emulated on

Re: [PATCH 4/5] mtd: spi-nor: Add driver for Adaptrum Anarion QSPI controller

2017-07-29 Thread kbuild test robot
Hi Alexandru, [auto build test WARNING on arc/for-next] [also build test WARNING on v4.13-rc2 next-20170728] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits/Alexandru-Gagniuc/Initial-support-for-

Re: [PATCH 4/5] mtd: spi-nor: Add driver for Adaptrum Anarion QSPI controller

2017-07-29 Thread Marek Vasut
On 07/29/2017 12:07 AM, Alexandru Gagniuc wrote: > Add support for the QSPI controller found in Adaptrum Anarion SOCs. > This controller is designed specifically to handle SPI NOR chips, and > the driver is modeled as such. > > Because the system is emulated on an FPGA, we don't have a way to test

[PATCH 4/5] mtd: spi-nor: Add driver for Adaptrum Anarion QSPI controller

2017-07-28 Thread Alexandru Gagniuc
Add support for the QSPI controller found in Adaptrum Anarion SOCs. This controller is designed specifically to handle SPI NOR chips, and the driver is modeled as such. Because the system is emulated on an FPGA, we don't have a way to test all the hardware adjustemts, so only basic features are im