Re: [PATCH 4/5] phy: tegra: xusb: Add support for power supplies

2019-02-07 Thread Thierry Reding
On Tue, Feb 05, 2019 at 06:25:04PM +0530, Kishon Vijay Abraham I wrote: > Hi, > > On 28/01/19 1:30 PM, Thierry Reding wrote: > > On Mon, Jan 28, 2019 at 03:22:09PM +0800, jckuo wrote: > >> Hi Thierry, > >> > >> I think any non-zero return value of > >> regulator_bulk_enable()/devm_regulator_bulk_g

Re: [PATCH 4/5] phy: tegra: xusb: Add support for power supplies

2019-02-05 Thread Kishon Vijay Abraham I
Hi, On 28/01/19 1:30 PM, Thierry Reding wrote: > On Mon, Jan 28, 2019 at 03:22:09PM +0800, jckuo wrote: >> Hi Thierry, >> >> I think any non-zero return value of >> regulator_bulk_enable()/devm_regulator_bulk_get() means error. >> >> Thanks, >> >> JC > > Theoretically I think only regulator_bulk_

Re: [PATCH 4/5] phy: tegra: xusb: Add support for power supplies

2019-01-28 Thread jckuo
Thanks Thierry. Reviewed-by: JC Kuo On 1/28/19 4:00 PM, Thierry Reding wrote: On Mon, Jan 28, 2019 at 03:22:09PM +0800, jckuo wrote: Hi Thierry, I think any non-zero return value of regulator_bulk_enable()/devm_regulator_bulk_get() means error. Thanks, JC Theoretically I think only regula

Re: [PATCH 4/5] phy: tegra: xusb: Add support for power supplies

2019-01-28 Thread Thierry Reding
On Mon, Jan 28, 2019 at 03:22:09PM +0800, jckuo wrote: > Hi Thierry, > > I think any non-zero return value of > regulator_bulk_enable()/devm_regulator_bulk_get() means error. > > Thanks, > > JC Theoretically I think only regulator_bulk_enable() could return a positive value, but even so it neve

Re: [PATCH 4/5] phy: tegra: xusb: Add support for power supplies

2019-01-27 Thread jckuo
Hi Thierry, I think any non-zero return value of regulator_bulk_enable()/devm_regulator_bulk_get() means error. Thanks, JC On 1/25/19 7:25 PM, Thierry Reding wrote: From: Thierry Reding Support enabling various supplies needed to provide power to the PLLs and logic used to drive the USB,

[PATCH 4/5] phy: tegra: xusb: Add support for power supplies

2019-01-25 Thread Thierry Reding
From: Thierry Reding Support enabling various supplies needed to provide power to the PLLs and logic used to drive the USB, PCI and SATA pads. Signed-off-by: Thierry Reding --- drivers/phy/tegra/xusb.c | 34 +- drivers/phy/tegra/xusb.h | 5 + 2 files change