Re: [PATCH 4/5] regulator: of: add missing of_node_put

2015-10-12 Thread Krzysztof Kozlowski
W dniu 12.10.2015 o 21:44, Julia Lawall pisze: > > > On Mon, 12 Oct 2015, Krzysztof Kozlowski wrote: > >> 2015-10-10 21:30 GMT+09:00 Julia Lawall : >>> >>> for_each_child_of_node performs an of_node_get on each iteration, so >>> a break out of the loop requires an of_node_put. >>> >>> The semant

Re: [PATCH 4/5] regulator: of: add missing of_node_put

2015-10-12 Thread Julia Lawall
On Mon, 12 Oct 2015, Krzysztof Kozlowski wrote: > 2015-10-10 21:30 GMT+09:00 Julia Lawall : > > > > for_each_child_of_node performs an of_node_get on each iteration, so > > a break out of the loop requires an of_node_put. > > > > The semantic patch that fixes this problem is as follows > > (http

Re: [PATCH 4/5] regulator: of: add missing of_node_put

2015-10-11 Thread Julia Lawall
On Mon, 12 Oct 2015, Krzysztof Kozlowski wrote: > 2015-10-10 21:30 GMT+09:00 Julia Lawall : > > > > for_each_child_of_node performs an of_node_get on each iteration, so > > a break out of the loop requires an of_node_put. > > > > The semantic patch that fixes this problem is as follows > > (http

Re: [PATCH 4/5] regulator: of: add missing of_node_put

2015-10-11 Thread Krzysztof Kozlowski
2015-10-10 21:30 GMT+09:00 Julia Lawall : > > for_each_child_of_node performs an of_node_get on each iteration, so > a break out of the loop requires an of_node_put. > > The semantic patch that fixes this problem is as follows > (http://coccinelle.lip6.fr): > > // > @@ > expression root,e; > local

[PATCH 4/5] regulator: of: add missing of_node_put

2015-10-10 Thread Julia Lawall
for_each_child_of_node performs an of_node_get on each iteration, so a break out of the loop requires an of_node_put. The semantic patch that fixes this problem is as follows (http://coccinelle.lip6.fr): // @@ expression root,e; local idexpression child; @@ for_each_child_of_node(root, child)