Re: [PATCH 4/5] s390/pci: Move an assignment for the variable "ret" in s390_pci_mmio_write()

2017-01-23 Thread Dan Carpenter
The original was more readable. regards, dan carpenter

[PATCH 4/5] s390/pci: Move an assignment for the variable "ret" in s390_pci_mmio_write()

2017-01-21 Thread SF Markus Elfring
From: Markus Elfring Date: Sat, 21 Jan 2017 18:35:00 +0100 A local variable was set to an error code before a concrete error situation was detected. Thus move the corresponding assignment into an if branch to indicate a software failure there. Signed-off-by: Markus Elfring --- arch/s390/pci/pc