Re: [PATCH 4/5] sched: don't consider upper se in sched_slice()

2013-04-04 Thread Joonsoo Kim
Hello, Preeti. On Thu, Apr 04, 2013 at 12:18:32PM +0530, Preeti U Murthy wrote: > Hi Joonsoo, > > On 04/04/2013 06:12 AM, Joonsoo Kim wrote: > > Hello, Preeti. > > > > > So, how about extending a sched_period with rq->nr_running, instead of > > cfs_rq->nr_running? It is my quick thought and I

Re: [PATCH 4/5] sched: don't consider upper se in sched_slice()

2013-04-04 Thread Preeti U Murthy
Hi Joonsoo, On 04/04/2013 06:12 AM, Joonsoo Kim wrote: > Hello, Preeti. > > So, how about extending a sched_period with rq->nr_running, instead of > cfs_rq->nr_running? It is my quick thought and I think that we can ensure > to run atleast once in this extending sched_period. Yeah this seems

Re: [PATCH 4/5] sched: don't consider upper se in sched_slice()

2013-04-04 Thread Preeti U Murthy
Hi Joonsoo, On 04/04/2013 06:12 AM, Joonsoo Kim wrote: Hello, Preeti. So, how about extending a sched_period with rq-nr_running, instead of cfs_rq-nr_running? It is my quick thought and I think that we can ensure to run atleast once in this extending sched_period. Yeah this seems to be

Re: [PATCH 4/5] sched: don't consider upper se in sched_slice()

2013-04-04 Thread Joonsoo Kim
Hello, Preeti. On Thu, Apr 04, 2013 at 12:18:32PM +0530, Preeti U Murthy wrote: Hi Joonsoo, On 04/04/2013 06:12 AM, Joonsoo Kim wrote: Hello, Preeti. So, how about extending a sched_period with rq-nr_running, instead of cfs_rq-nr_running? It is my quick thought and I think that we

Re: [PATCH 4/5] sched: don't consider upper se in sched_slice()

2013-04-03 Thread Joonsoo Kim
Hello, Preeti. On Tue, Apr 02, 2013 at 11:02:43PM +0530, Preeti U Murthy wrote: > Hi Joonsoo, > > > >>> I think that it is real problem that sysctl_sched_min_granularity is not > >>> guaranteed for each task. > >>> Instead of this patch, how about considering low bound? > >>> > >>> if (slice <

Re: [PATCH 4/5] sched: don't consider upper se in sched_slice()

2013-04-03 Thread Joonsoo Kim
Hello, Preeti. On Tue, Apr 02, 2013 at 11:02:43PM +0530, Preeti U Murthy wrote: Hi Joonsoo, I think that it is real problem that sysctl_sched_min_granularity is not guaranteed for each task. Instead of this patch, how about considering low bound? if (slice

Re: [PATCH 4/5] sched: don't consider upper se in sched_slice()

2013-04-02 Thread Preeti U Murthy
Hi Joonsoo, >>> I think that it is real problem that sysctl_sched_min_granularity is not >>> guaranteed for each task. >>> Instead of this patch, how about considering low bound? >>> >>> if (slice < sysctl_sched_min_granularity) >>> slice = sysctl_sched_min_granularity; >> >> Consider the

Re: [PATCH 4/5] sched: don't consider upper se in sched_slice()

2013-04-02 Thread Joonsoo Kim
Hello, Mike. On Tue, Apr 02, 2013 at 04:35:26AM +0200, Mike Galbraith wrote: > On Tue, 2013-04-02 at 11:25 +0900, Joonsoo Kim wrote: > > Hello, Preeti. > > > > On Mon, Apr 01, 2013 at 12:36:52PM +0530, Preeti U Murthy wrote: > > > Hi Joonsoo, > > > > > > On 04/01/2013 09:38 AM, Joonsoo Kim

Re: [PATCH 4/5] sched: don't consider upper se in sched_slice()

2013-04-02 Thread Joonsoo Kim
Hello, Preeti. On Tue, Apr 02, 2013 at 10:25:23AM +0530, Preeti U Murthy wrote: > Hi Joonsoo, > > On 04/02/2013 07:55 AM, Joonsoo Kim wrote: > > Hello, Preeti. > > > > On Mon, Apr 01, 2013 at 12:36:52PM +0530, Preeti U Murthy wrote: > >> Hi Joonsoo, > >> > >> On 04/01/2013 09:38 AM, Joonsoo Kim

Re: [PATCH 4/5] sched: don't consider upper se in sched_slice()

2013-04-02 Thread Joonsoo Kim
Hello, Preeti. On Tue, Apr 02, 2013 at 10:25:23AM +0530, Preeti U Murthy wrote: Hi Joonsoo, On 04/02/2013 07:55 AM, Joonsoo Kim wrote: Hello, Preeti. On Mon, Apr 01, 2013 at 12:36:52PM +0530, Preeti U Murthy wrote: Hi Joonsoo, On 04/01/2013 09:38 AM, Joonsoo Kim wrote: Hello,

Re: [PATCH 4/5] sched: don't consider upper se in sched_slice()

2013-04-02 Thread Joonsoo Kim
Hello, Mike. On Tue, Apr 02, 2013 at 04:35:26AM +0200, Mike Galbraith wrote: On Tue, 2013-04-02 at 11:25 +0900, Joonsoo Kim wrote: Hello, Preeti. On Mon, Apr 01, 2013 at 12:36:52PM +0530, Preeti U Murthy wrote: Hi Joonsoo, On 04/01/2013 09:38 AM, Joonsoo Kim wrote: Hello,

Re: [PATCH 4/5] sched: don't consider upper se in sched_slice()

2013-04-02 Thread Preeti U Murthy
Hi Joonsoo, I think that it is real problem that sysctl_sched_min_granularity is not guaranteed for each task. Instead of this patch, how about considering low bound? if (slice sysctl_sched_min_granularity) slice = sysctl_sched_min_granularity; Consider the below scenario. A

Re: [PATCH 4/5] sched: don't consider upper se in sched_slice()

2013-04-01 Thread Preeti U Murthy
Hi Joonsoo, On 04/02/2013 07:55 AM, Joonsoo Kim wrote: > Hello, Preeti. > > On Mon, Apr 01, 2013 at 12:36:52PM +0530, Preeti U Murthy wrote: >> Hi Joonsoo, >> >> On 04/01/2013 09:38 AM, Joonsoo Kim wrote: >>> Hello, Preeti. >>> >> Ideally the children's cpu share must add upto the

Re: [PATCH 4/5] sched: don't consider upper se in sched_slice()

2013-04-01 Thread Mike Galbraith
On Tue, 2013-04-02 at 11:25 +0900, Joonsoo Kim wrote: > Hello, Preeti. > > On Mon, Apr 01, 2013 at 12:36:52PM +0530, Preeti U Murthy wrote: > > Hi Joonsoo, > > > > On 04/01/2013 09:38 AM, Joonsoo Kim wrote: > > > Hello, Preeti. > > > > > > > >> > > >> Ideally the children's cpu share must add

Re: [PATCH 4/5] sched: don't consider upper se in sched_slice()

2013-04-01 Thread Joonsoo Kim
Hello, Preeti. On Mon, Apr 01, 2013 at 12:36:52PM +0530, Preeti U Murthy wrote: > Hi Joonsoo, > > On 04/01/2013 09:38 AM, Joonsoo Kim wrote: > > Hello, Preeti. > > > > >> > >> Ideally the children's cpu share must add upto the parent's share. > >> > > > > I don't think so. > > > > We should

Re: [PATCH 4/5] sched: don't consider upper se in sched_slice()

2013-04-01 Thread Preeti U Murthy
Hi Joonsoo, On 04/01/2013 09:38 AM, Joonsoo Kim wrote: > Hello, Preeti. > >> >> Ideally the children's cpu share must add upto the parent's share. >> > > I don't think so. > > We should schedule out the parent tg if 5ms is over. As we do so, we can > fairly distribute time slice to every tg

Re: [PATCH 4/5] sched: don't consider upper se in sched_slice()

2013-04-01 Thread Preeti U Murthy
Hi Joonsoo, On 04/01/2013 09:38 AM, Joonsoo Kim wrote: Hello, Preeti. Ideally the children's cpu share must add upto the parent's share. I don't think so. We should schedule out the parent tg if 5ms is over. As we do so, we can fairly distribute time slice to every tg within short

Re: [PATCH 4/5] sched: don't consider upper se in sched_slice()

2013-04-01 Thread Joonsoo Kim
Hello, Preeti. On Mon, Apr 01, 2013 at 12:36:52PM +0530, Preeti U Murthy wrote: Hi Joonsoo, On 04/01/2013 09:38 AM, Joonsoo Kim wrote: Hello, Preeti. Ideally the children's cpu share must add upto the parent's share. I don't think so. We should schedule out the parent

Re: [PATCH 4/5] sched: don't consider upper se in sched_slice()

2013-04-01 Thread Mike Galbraith
On Tue, 2013-04-02 at 11:25 +0900, Joonsoo Kim wrote: Hello, Preeti. On Mon, Apr 01, 2013 at 12:36:52PM +0530, Preeti U Murthy wrote: Hi Joonsoo, On 04/01/2013 09:38 AM, Joonsoo Kim wrote: Hello, Preeti. Ideally the children's cpu share must add upto the parent's share.

Re: [PATCH 4/5] sched: don't consider upper se in sched_slice()

2013-04-01 Thread Preeti U Murthy
Hi Joonsoo, On 04/02/2013 07:55 AM, Joonsoo Kim wrote: Hello, Preeti. On Mon, Apr 01, 2013 at 12:36:52PM +0530, Preeti U Murthy wrote: Hi Joonsoo, On 04/01/2013 09:38 AM, Joonsoo Kim wrote: Hello, Preeti. Ideally the children's cpu share must add upto the parent's share. I don't

Re: [PATCH 4/5] sched: don't consider upper se in sched_slice()

2013-03-31 Thread Joonsoo Kim
Hello, Preeti. On Fri, Mar 29, 2013 at 12:42:53PM +0530, Preeti U Murthy wrote: > Hi Joonsoo, > > On 03/28/2013 01:28 PM, Joonsoo Kim wrote: > > Following-up upper se in sched_slice() should not be done, > > because sched_slice() is used for checking that resched is needed > > whithin *this*

Re: [PATCH 4/5] sched: don't consider upper se in sched_slice()

2013-03-31 Thread Joonsoo Kim
Hello, Preeti. On Fri, Mar 29, 2013 at 12:42:53PM +0530, Preeti U Murthy wrote: Hi Joonsoo, On 03/28/2013 01:28 PM, Joonsoo Kim wrote: Following-up upper se in sched_slice() should not be done, because sched_slice() is used for checking that resched is needed whithin *this* cfs_rq and

Re: [PATCH 4/5] sched: don't consider upper se in sched_slice()

2013-03-29 Thread Preeti U Murthy
Hi Joonsoo, On 03/28/2013 01:28 PM, Joonsoo Kim wrote: > Following-up upper se in sched_slice() should not be done, > because sched_slice() is used for checking that resched is needed > whithin *this* cfs_rq and there is one problem related to this > in current implementation. > > The problem is

Re: [PATCH 4/5] sched: don't consider upper se in sched_slice()

2013-03-29 Thread Preeti U Murthy
Hi Joonsoo, On 03/28/2013 01:28 PM, Joonsoo Kim wrote: Following-up upper se in sched_slice() should not be done, because sched_slice() is used for checking that resched is needed whithin *this* cfs_rq and there is one problem related to this in current implementation. The problem is that

[PATCH 4/5] sched: don't consider upper se in sched_slice()

2013-03-28 Thread Joonsoo Kim
Following-up upper se in sched_slice() should not be done, because sched_slice() is used for checking that resched is needed whithin *this* cfs_rq and there is one problem related to this in current implementation. The problem is that if we follow-up upper se in sched_slice(), it is possible that

[PATCH 4/5] sched: don't consider upper se in sched_slice()

2013-03-28 Thread Joonsoo Kim
Following-up upper se in sched_slice() should not be done, because sched_slice() is used for checking that resched is needed whithin *this* cfs_rq and there is one problem related to this in current implementation. The problem is that if we follow-up upper se in sched_slice(), it is possible that