Re: [PATCH 4/5] scsi: megaraid_sas - preallocate memory for ioctl processing

2007-02-08 Thread Christoph Hellwig
On Wed, Feb 07, 2007 at 01:30:20PM -0800, Andrew Morton wrote: > On Tue, 06 Feb 2007 14:19:54 -0800 > Sumant Patro <[EMAIL PROTECTED]> wrote: > > > Preallocate memory for ioctl processing. This is to avoid situations > > where ioctl fails for lack of memory (when system under heavy stress). > > T

Re: [PATCH 4/5] scsi: megaraid_sas - preallocate memory for ioctl processing

2007-02-07 Thread James Bottomley
On Wed, 2007-02-07 at 13:30 -0800, Andrew Morton wrote: > I suspect all this horror is due to stupidity in the DMA API. > > pci_alloc_consistent() just goes and assumes GFP_ATOMIC, whereas > the caller (megasas_mgmt_fw_ioctl) would have been perfectly happy > to use GFP_KERNEL. > > I bet this fix

Re: [PATCH 4/5] scsi: megaraid_sas - preallocate memory for ioctl processing

2007-02-07 Thread Andrew Morton
On Tue, 06 Feb 2007 14:19:54 -0800 Sumant Patro <[EMAIL PROTECTED]> wrote: > Preallocate memory for ioctl processing. This is to avoid situations > where ioctl fails for lack of memory (when system under heavy stress). > The memory pool will have 8*4K, 4*8K and 1*64K memory chunks mutter. I sus

[PATCH 4/5] scsi: megaraid_sas - preallocate memory for ioctl processing

2007-02-06 Thread Sumant Patro
Preallocate memory for ioctl processing. This is to avoid situations where ioctl fails for lack of memory (when system under heavy stress). The memory pool will have 8*4K, 4*8K and 1*64K memory chunks Signed-off-by: Sumant Patro <[EMAIL PROTECTED]> drivers/scsi/megaraid/megaraid_sas.c | 257 ++