Re: [PATCH 4/5] staging: sm7xxfb: define new macros

2015-07-14 Thread Sudip Mukherjee
On Tue, Jul 14, 2015 at 08:05:08PM -0700, Greg Kroah-Hartman wrote: > On Tue, Jul 07, 2015 at 01:44:36PM +0530, Sudip Mukherjee wrote: > > +#define mmio_addr 0x00c0 > > +#define seqw17 > > Odd, empty macros are not good, because: > > > -#ifdef __BIG_ENDIAN > > if (sfb->fb

Re: [PATCH 4/5] staging: sm7xxfb: define new macros

2015-07-14 Thread Greg Kroah-Hartman
On Tue, Jul 07, 2015 at 01:44:36PM +0530, Sudip Mukherjee wrote: > Define and use some new macros to work with different situations > based on little-endian and big-endian. > > Signed-off-by: Sudip Mukherjee > --- > drivers/staging/sm7xxfb/sm7xx.h | 19 > drivers/staging/sm7xx

[PATCH 4/5] staging: sm7xxfb: define new macros

2015-07-07 Thread Sudip Mukherjee
Define and use some new macros to work with different situations based on little-endian and big-endian. Signed-off-by: Sudip Mukherjee --- drivers/staging/sm7xxfb/sm7xx.h | 19 drivers/staging/sm7xxfb/sm7xxfb.c | 48 --- 2 files changed, 29