Re: [PATCH 4/5] tpm_tis_spi: Remove limitation of transfers to MAX_SPI_FRAMESIZE bytes

2017-02-24 Thread Jarkko Sakkinen
On Thu, Feb 16, 2017 at 04:08:25PM +, Peter Huewe wrote: > Limiting transfers to MAX_SPI_FRAMESIZE was not expected by the upper > layers, as tpm_tis has no such limitation. Add a loop to hide that > limitation. > > Cc: > Fixes: 0edbfea537d1 ("tpm/tpm_tis_spi: Add

Re: [PATCH 4/5] tpm_tis_spi: Remove limitation of transfers to MAX_SPI_FRAMESIZE bytes

2017-02-24 Thread Jarkko Sakkinen
On Thu, Feb 16, 2017 at 04:08:25PM +, Peter Huewe wrote: > Limiting transfers to MAX_SPI_FRAMESIZE was not expected by the upper > layers, as tpm_tis has no such limitation. Add a loop to hide that > limitation. > > Cc: > Fixes: 0edbfea537d1 ("tpm/tpm_tis_spi: Add support for spi phy") >

Re: [PATCH 4/5] tpm_tis_spi: Remove limitation of transfers to MAX_SPI_FRAMESIZE bytes

2017-02-24 Thread Jarkko Sakkinen
On Thu, Feb 16, 2017 at 04:08:25PM +, Peter Huewe wrote: > Limiting transfers to MAX_SPI_FRAMESIZE was not expected by the upper > layers, as tpm_tis has no such limitation. Add a loop to hide that > limitation. > > Cc: > Fixes: 0edbfea537d1 ("tpm/tpm_tis_spi: Add

Re: [PATCH 4/5] tpm_tis_spi: Remove limitation of transfers to MAX_SPI_FRAMESIZE bytes

2017-02-24 Thread Jarkko Sakkinen
On Thu, Feb 16, 2017 at 04:08:25PM +, Peter Huewe wrote: > Limiting transfers to MAX_SPI_FRAMESIZE was not expected by the upper > layers, as tpm_tis has no such limitation. Add a loop to hide that > limitation. > > Cc: > Fixes: 0edbfea537d1 ("tpm/tpm_tis_spi: Add support for spi phy") >

Re: [PATCH 4/5] tpm_tis_spi: Remove limitation of transfers to MAX_SPI_FRAMESIZE bytes

2017-02-16 Thread Peter Huewe
Am 17. Februar 2017 06:11:53 MEZ schrieb Christophe Ricard : >I am not sure i understand here, are you considering there could be >burstcount > 64 with "TCG" TPM ? > With the current upstream version, any command larger with a response of more than 64 byte is

Re: [PATCH 4/5] tpm_tis_spi: Remove limitation of transfers to MAX_SPI_FRAMESIZE bytes

2017-02-16 Thread Peter Huewe
Am 17. Februar 2017 06:11:53 MEZ schrieb Christophe Ricard : >I am not sure i understand here, are you considering there could be >burstcount > 64 with "TCG" TPM ? > With the current upstream version, any command larger with a response of more than 64 byte is broken, since the splitting loop

Re: [PATCH 4/5] tpm_tis_spi: Remove limitation of transfers to MAX_SPI_FRAMESIZE bytes

2017-02-16 Thread Christophe Ricard
I am not sure i understand here, are you considering there could be burstcount > 64 with "TCG" TPM ? Or is this because of TIS vs PTP differences ? To be honest, this is a little behind me now :-) On 16/02/2017 08:08, Peter Huewe wrote: Limiting transfers to MAX_SPI_FRAMESIZE was not

Re: [PATCH 4/5] tpm_tis_spi: Remove limitation of transfers to MAX_SPI_FRAMESIZE bytes

2017-02-16 Thread Christophe Ricard
I am not sure i understand here, are you considering there could be burstcount > 64 with "TCG" TPM ? Or is this because of TIS vs PTP differences ? To be honest, this is a little behind me now :-) On 16/02/2017 08:08, Peter Huewe wrote: Limiting transfers to MAX_SPI_FRAMESIZE was not

Re: [PATCH 4/5] tpm_tis_spi: Remove limitation of transfers to MAX_SPI_FRAMESIZE bytes

2017-02-16 Thread kbuild test robot
Hi Peter, [auto build test WARNING on char-misc/char-misc-testing] [also build test WARNING on v4.10-rc8 next-20170216] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url:

Re: [PATCH 4/5] tpm_tis_spi: Remove limitation of transfers to MAX_SPI_FRAMESIZE bytes

2017-02-16 Thread kbuild test robot
Hi Peter, [auto build test WARNING on char-misc/char-misc-testing] [also build test WARNING on v4.10-rc8 next-20170216] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url:

[PATCH 4/5] tpm_tis_spi: Remove limitation of transfers to MAX_SPI_FRAMESIZE bytes

2017-02-16 Thread Peter Huewe
Limiting transfers to MAX_SPI_FRAMESIZE was not expected by the upper layers, as tpm_tis has no such limitation. Add a loop to hide that limitation. Cc: Fixes: 0edbfea537d1 ("tpm/tpm_tis_spi: Add support for spi phy") Signed-off-by: Alexander Steffen

[PATCH 4/5] tpm_tis_spi: Remove limitation of transfers to MAX_SPI_FRAMESIZE bytes

2017-02-16 Thread Peter Huewe
Limiting transfers to MAX_SPI_FRAMESIZE was not expected by the upper layers, as tpm_tis has no such limitation. Add a loop to hide that limitation. Cc: Fixes: 0edbfea537d1 ("tpm/tpm_tis_spi: Add support for spi phy") Signed-off-by: Alexander Steffen Signed-off-by: Peter Huewe ---