Re: [PATCH 4/5] zram: remove zram_meta structure

2017-04-03 Thread Sergey Senozhatsky
On (04/04/17 14:40), Minchan Kim wrote: > > [..] > > > -struct zram_meta { > > > +struct zram { > > > struct zram_table_entry *table; > > > struct zs_pool *mem_pool; > > > -}; > > > - > > > -struct zram { > > > - struct zram_meta *meta; > > > struct zcomp *comp; > > > struct gendisk *disk;

Re: [PATCH 4/5] zram: remove zram_meta structure

2017-04-03 Thread Minchan Kim
On Tue, Apr 04, 2017 at 11:31:15AM +0900, Sergey Senozhatsky wrote: < snip > > > [..] > > -struct zram_meta { > > +struct zram { > > struct zram_table_entry *table; > > struct zs_pool *mem_pool; > > -}; > > - > > -struct zram { > > - struct zram_meta *meta; > > struct zcomp *comp; >

Re: [PATCH 4/5] zram: remove zram_meta structure

2017-04-03 Thread Minchan Kim
On Tue, Apr 04, 2017 at 11:31:15AM +0900, Sergey Senozhatsky wrote: > On (04/03/17 14:17), Minchan Kim wrote: > [..] > > -static struct zram_meta *zram_meta_alloc(char *pool_name, u64 disksize) > > +static bool zram_meta_alloc(struct zram *zram, u64 disksize) > > { > > size_t num_pages; > > -

Re: [PATCH 4/5] zram: remove zram_meta structure

2017-04-03 Thread Sergey Senozhatsky
On (04/03/17 14:17), Minchan Kim wrote: [..] > -static struct zram_meta *zram_meta_alloc(char *pool_name, u64 disksize) > +static bool zram_meta_alloc(struct zram *zram, u64 disksize) > { > size_t num_pages; > - struct zram_meta *meta = kmalloc(sizeof(*meta), GFP_KERNEL); > - > - if

[PATCH 4/5] zram: remove zram_meta structure

2017-04-02 Thread Minchan Kim
It's redundant now. Instead, remove it and use zram structure directly. Signed-off-by: Minchan Kim --- drivers/block/zram/zram_drv.c | 163 +- drivers/block/zram/zram_drv.h | 6 +- 2 files changed, 65 insertions(+), 104 deletions(-) diff --git a/drivers