Re: [PATCH 4/5 V4] PCI: only return true when dev io state is really changed

2020-09-28 Thread Andy Shevchenko
On Mon, Sep 28, 2020 at 7:13 AM Ethan Zhao wrote: > > When uncorrectable error happens, AER driver and DPC driver interrupt > handlers likely call > >pcie_do_recovery() >->pci_walk_bus() > ->report_frozen_detected() > > with pci_channel_io_frozen the same time. >If pci_dev_set_io_

[PATCH 4/5 V4] PCI: only return true when dev io state is really changed

2020-09-27 Thread Ethan Zhao
When uncorrectable error happens, AER driver and DPC driver interrupt handlers likely call pcie_do_recovery() ->pci_walk_bus() ->report_frozen_detected() with pci_channel_io_frozen the same time. If pci_dev_set_io_state() return true even if the original state is pci_channel_io_froz

RE: [PATCH 4/5 V4] PCI: only return true when dev io state is really changed

2020-09-27 Thread Zhao, Haifeng
...@gmail.com; mr.nuke...@gmail.com; mika.westerb...@linux.intel.com Cc: linux-...@vger.kernel.org; linux-kernel@vger.kernel.org; Jia, Pei P ; ashok@linux.intel.com; Kuppuswamy, Sathyanarayanan ; h...@infradead.org Subject: Re: [PATCH 4/5 V4] PCI: only return true when dev io state is really

Re: [PATCH 4/5 V4] PCI: only return true when dev io state is really changed

2020-09-27 Thread Joe Perches
On Sun, 2020-09-27 at 04:27 -0400, Ethan Zhao wrote: > When uncorrectable error happens, AER driver and DPC driver interrupt > handlers likely call > >pcie_do_recovery() >->pci_walk_bus() > ->report_frozen_detected() > > with pci_channel_io_frozen the same time. >If pci_dev_set_i

[PATCH 4/5 V4] PCI: only return true when dev io state is really changed

2020-09-27 Thread Ethan Zhao
When uncorrectable error happens, AER driver and DPC driver interrupt handlers likely call pcie_do_recovery() ->pci_walk_bus() ->report_frozen_detected() with pci_channel_io_frozen the same time. If pci_dev_set_io_state() return true even if the original state is pci_channel_io_froz