Re: [PATCH 4/6] arm: mach-omap2: remove "OMAP_DEVICE_NO_IDLE_ON_SUSPEND" check

2013-04-21 Thread Sourav Poddar
Hi Kevin, On Friday 19 April 2013 08:22 PM, Kevin Hilman wrote: Sourav Poddar writes: [...] Yes, got your point. omap_device_idle should not be called only for console uart. Just did a quick testing by including the following hunk on top of my patch series.. diff --git a/arch/arm/mach-omap2

Re: [PATCH 4/6] arm: mach-omap2: remove "OMAP_DEVICE_NO_IDLE_ON_SUSPEND" check

2013-04-19 Thread Kevin Hilman
Sourav Poddar writes: [...] > Yes, got your point. omap_device_idle should not be called only > for console uart. > > Just did a quick testing by including the following hunk on top of my > patch series.. > > diff --git a/arch/arm/mach-omap2/omap_device.c > b/arch/arm/mach-omap2/omap_device.c >

Re: [PATCH 4/6] arm: mach-omap2: remove "OMAP_DEVICE_NO_IDLE_ON_SUSPEND" check

2013-04-19 Thread Sourav Poddar
Hi Kevin, On Friday 19 April 2013 03:33 AM, Kevin Hilman wrote: Sourav Poddar writes: On Thursday 18 April 2013 11:35 PM, Kevin Hilman wrote: Sourav Poddar writes: Remove the "OMAP_DEVICE_NO_IDLE_ON_SUSPEND" check, since UART was the only one making use of it. Now serial core/driver take

Re: [PATCH 4/6] arm: mach-omap2: remove "OMAP_DEVICE_NO_IDLE_ON_SUSPEND" check

2013-04-18 Thread Kevin Hilman
Sourav Poddar writes: > On Thursday 18 April 2013 11:35 PM, Kevin Hilman wrote: >> Sourav Poddar writes: >> >>> Remove the "OMAP_DEVICE_NO_IDLE_ON_SUSPEND" check, since UART was the only >>> one making >>> use of it. Now serial core/driver takes care of the case when >>> "no_console_suspend" >

Re: [PATCH 4/6] arm: mach-omap2: remove "OMAP_DEVICE_NO_IDLE_ON_SUSPEND" check

2013-04-18 Thread Sourav Poddar
On Thursday 18 April 2013 11:35 PM, Kevin Hilman wrote: Sourav Poddar writes: Remove the "OMAP_DEVICE_NO_IDLE_ON_SUSPEND" check, since UART was the only one making use of it. Now serial core/driver takes care of the case when "no_console_suspend" is used in the bootargs and you need to keep

Re: [PATCH 4/6] arm: mach-omap2: remove "OMAP_DEVICE_NO_IDLE_ON_SUSPEND" check

2013-04-18 Thread Kevin Hilman
Sourav Poddar writes: > Remove the "OMAP_DEVICE_NO_IDLE_ON_SUSPEND" check, since UART was the only > one making > use of it. Now serial core/driver takes care of the case when > "no_console_suspend" > is used in the bootargs and you need to keep the clock enable for console > even while suspe

[PATCH 4/6] arm: mach-omap2: remove "OMAP_DEVICE_NO_IDLE_ON_SUSPEND" check

2013-04-17 Thread Sourav Poddar
Remove the "OMAP_DEVICE_NO_IDLE_ON_SUSPEND" check, since UART was the only one making use of it. Now serial core/driver takes care of the case when "no_console_suspend" is used in the bootargs and you need to keep the clock enable for console even while suspend. Signed-off-by: Sourav Poddar -