Re: [fuse-devel] [PATCH 4/6] fs/fuse: support compiling out splice

2014-11-24 Thread Pieter Smith
On Mon, Nov 24, 2014 at 12:22:14PM -0800, Greg KH wrote: > On Mon, Nov 24, 2014 at 12:14:50PM -0800, j...@joshtriplett.org wrote: > > > I would, again, argue that stuff like __splice_p() not be implemented at > > > all please. It will only cause a huge proliferation of stuff like this > > > that

Re: [fuse-devel] [PATCH 4/6] fs/fuse: support compiling out splice

2014-11-24 Thread Greg KH
On Mon, Nov 24, 2014 at 12:14:50PM -0800, j...@joshtriplett.org wrote: > > I would, again, argue that stuff like __splice_p() not be implemented at > > all please. It will only cause a huge proliferation of stuff like this > > that will not make any sense, and only cause a trivial, if any, amount

Re: [fuse-devel] [PATCH 4/6] fs/fuse: support compiling out splice

2014-11-24 Thread josh
On Mon, Nov 24, 2014 at 11:34:12AM -0800, Greg KH wrote: > On Mon, Nov 24, 2014 at 08:05:10AM -0800, Josh Triplett wrote: > > On Mon, Nov 24, 2014 at 10:49:31AM +0100, Pieter Smith wrote: > > > On Sun, Nov 23, 2014 at 03:23:02PM -0800, Josh Triplett wrote: > > > > On Sun, Nov 23, 2014 at

Re: [fuse-devel] [PATCH 4/6] fs/fuse: support compiling out splice

2014-11-24 Thread Greg KH
On Mon, Nov 24, 2014 at 08:05:10AM -0800, Josh Triplett wrote: > On Mon, Nov 24, 2014 at 10:49:31AM +0100, Pieter Smith wrote: > > On Sun, Nov 23, 2014 at 03:23:02PM -0800, Josh Triplett wrote: > > > On Sun, Nov 23, 2014 at 11:29:08PM +0100, Richard Weinberger wrote: > > > > On Sun, Nov 23, 2014

Re: [fuse-devel] [PATCH 4/6] fs/fuse: support compiling out splice

2014-11-24 Thread Josh Triplett
On Mon, Nov 24, 2014 at 10:49:31AM +0100, Pieter Smith wrote: > On Sun, Nov 23, 2014 at 03:23:02PM -0800, Josh Triplett wrote: > > On Sun, Nov 23, 2014 at 11:29:08PM +0100, Richard Weinberger wrote: > > > On Sun, Nov 23, 2014 at 3:20 PM, Pieter Smith wrote: > > > > To implement splice support,

Re: [fuse-devel] [PATCH 4/6] fs/fuse: support compiling out splice

2014-11-24 Thread Pieter Smith
On Sun, Nov 23, 2014 at 03:23:02PM -0800, Josh Triplett wrote: > On Sun, Nov 23, 2014 at 11:29:08PM +0100, Richard Weinberger wrote: > > On Sun, Nov 23, 2014 at 3:20 PM, Pieter Smith wrote: > > > To implement splice support, fs/fuse makes use of nosteal_pipe_buf_ops. > > > This > > > struct is

Re: [fuse-devel] [PATCH 4/6] fs/fuse: support compiling out splice

2014-11-24 Thread Pieter Smith
On Sun, Nov 23, 2014 at 03:23:02PM -0800, Josh Triplett wrote: On Sun, Nov 23, 2014 at 11:29:08PM +0100, Richard Weinberger wrote: On Sun, Nov 23, 2014 at 3:20 PM, Pieter Smith pie...@boesman.nl wrote: To implement splice support, fs/fuse makes use of nosteal_pipe_buf_ops. This struct

Re: [fuse-devel] [PATCH 4/6] fs/fuse: support compiling out splice

2014-11-24 Thread Josh Triplett
On Mon, Nov 24, 2014 at 10:49:31AM +0100, Pieter Smith wrote: On Sun, Nov 23, 2014 at 03:23:02PM -0800, Josh Triplett wrote: On Sun, Nov 23, 2014 at 11:29:08PM +0100, Richard Weinberger wrote: On Sun, Nov 23, 2014 at 3:20 PM, Pieter Smith pie...@boesman.nl wrote: To implement splice

Re: [fuse-devel] [PATCH 4/6] fs/fuse: support compiling out splice

2014-11-24 Thread Greg KH
On Mon, Nov 24, 2014 at 08:05:10AM -0800, Josh Triplett wrote: On Mon, Nov 24, 2014 at 10:49:31AM +0100, Pieter Smith wrote: On Sun, Nov 23, 2014 at 03:23:02PM -0800, Josh Triplett wrote: On Sun, Nov 23, 2014 at 11:29:08PM +0100, Richard Weinberger wrote: On Sun, Nov 23, 2014 at 3:20 PM,

Re: [fuse-devel] [PATCH 4/6] fs/fuse: support compiling out splice

2014-11-24 Thread josh
On Mon, Nov 24, 2014 at 11:34:12AM -0800, Greg KH wrote: On Mon, Nov 24, 2014 at 08:05:10AM -0800, Josh Triplett wrote: On Mon, Nov 24, 2014 at 10:49:31AM +0100, Pieter Smith wrote: On Sun, Nov 23, 2014 at 03:23:02PM -0800, Josh Triplett wrote: On Sun, Nov 23, 2014 at 11:29:08PM +0100,

Re: [fuse-devel] [PATCH 4/6] fs/fuse: support compiling out splice

2014-11-24 Thread Greg KH
On Mon, Nov 24, 2014 at 12:14:50PM -0800, j...@joshtriplett.org wrote: I would, again, argue that stuff like __splice_p() not be implemented at all please. It will only cause a huge proliferation of stuff like this that will not make any sense, and only cause a trivial, if any, amount of

Re: [fuse-devel] [PATCH 4/6] fs/fuse: support compiling out splice

2014-11-24 Thread Pieter Smith
On Mon, Nov 24, 2014 at 12:22:14PM -0800, Greg KH wrote: On Mon, Nov 24, 2014 at 12:14:50PM -0800, j...@joshtriplett.org wrote: I would, again, argue that stuff like __splice_p() not be implemented at all please. It will only cause a huge proliferation of stuff like this that will not

Re: [fuse-devel] [PATCH 4/6] fs/fuse: support compiling out splice

2014-11-23 Thread Josh Triplett
On Sun, Nov 23, 2014 at 11:29:08PM +0100, Richard Weinberger wrote: > On Sun, Nov 23, 2014 at 3:20 PM, Pieter Smith wrote: > > To implement splice support, fs/fuse makes use of nosteal_pipe_buf_ops. This > > struct is exported by fs/splice. The goal of the larger patch set is to > > completely

Re: [fuse-devel] [PATCH 4/6] fs/fuse: support compiling out splice

2014-11-23 Thread Richard Weinberger
On Sun, Nov 23, 2014 at 3:20 PM, Pieter Smith wrote: > To implement splice support, fs/fuse makes use of nosteal_pipe_buf_ops. This > struct is exported by fs/splice. The goal of the larger patch set is to > completely compile out fs/splice, so uses of the exported struct need to be > compiled

[PATCH 4/6] fs/fuse: support compiling out splice

2014-11-23 Thread Pieter Smith
To implement splice support, fs/fuse makes use of nosteal_pipe_buf_ops. This struct is exported by fs/splice. The goal of the larger patch set is to completely compile out fs/splice, so uses of the exported struct need to be compiled out along with fs/splice. This patch therefore compiles out

[PATCH 4/6] fs/fuse: support compiling out splice

2014-11-23 Thread Pieter Smith
To implement splice support, fs/fuse makes use of nosteal_pipe_buf_ops. This struct is exported by fs/splice. The goal of the larger patch set is to completely compile out fs/splice, so uses of the exported struct need to be compiled out along with fs/splice. This patch therefore compiles out

Re: [fuse-devel] [PATCH 4/6] fs/fuse: support compiling out splice

2014-11-23 Thread Richard Weinberger
On Sun, Nov 23, 2014 at 3:20 PM, Pieter Smith pie...@boesman.nl wrote: To implement splice support, fs/fuse makes use of nosteal_pipe_buf_ops. This struct is exported by fs/splice. The goal of the larger patch set is to completely compile out fs/splice, so uses of the exported struct need to be

Re: [fuse-devel] [PATCH 4/6] fs/fuse: support compiling out splice

2014-11-23 Thread Josh Triplett
On Sun, Nov 23, 2014 at 11:29:08PM +0100, Richard Weinberger wrote: On Sun, Nov 23, 2014 at 3:20 PM, Pieter Smith pie...@boesman.nl wrote: To implement splice support, fs/fuse makes use of nosteal_pipe_buf_ops. This struct is exported by fs/splice. The goal of the larger patch set is to

Re: [PATCH 4/6] fs/fuse: support compiling out splice

2014-11-22 Thread Josh Triplett
On Sat, Nov 22, 2014 at 09:59:59PM +0100, Pieter Smith wrote: > Compile out splice support from fuse when the splice-family of syscalls is not > supported by the system (i.e. CONFIG_SYSCALL_SPLICE is undefined). This patch needs some additional explanation. Could you explain in the commit

[PATCH 4/6] fs/fuse: support compiling out splice

2014-11-22 Thread Pieter Smith
Compile out splice support from fuse when the splice-family of syscalls is not supported by the system (i.e. CONFIG_SYSCALL_SPLICE is undefined). Signed-off-by: Pieter Smith --- fs/fuse/dev.c | 4 ++-- include/linux/fs.h | 6 ++ 2 files changed, 8 insertions(+), 2 deletions(-) diff

[PATCH 4/6] fs/fuse: support compiling out splice

2014-11-22 Thread Pieter Smith
Compile out splice support from fuse when the splice-family of syscalls is not supported by the system (i.e. CONFIG_SYSCALL_SPLICE is undefined). Signed-off-by: Pieter Smith pie...@boesman.nl --- fs/fuse/dev.c | 4 ++-- include/linux/fs.h | 6 ++ 2 files changed, 8 insertions(+), 2

Re: [PATCH 4/6] fs/fuse: support compiling out splice

2014-11-22 Thread Josh Triplett
On Sat, Nov 22, 2014 at 09:59:59PM +0100, Pieter Smith wrote: Compile out splice support from fuse when the splice-family of syscalls is not supported by the system (i.e. CONFIG_SYSCALL_SPLICE is undefined). This patch needs some additional explanation. Could you explain in the commit message