Re: [PATCH 4/6] i2c: busses: add SLIMpro I2C device driver on APM X-Gene platform

2015-02-02 Thread Wolfram Sang
On Mon, Feb 02, 2015 at 02:15:44PM -0800, Feng Kan wrote: > On Thu, Jan 29, 2015 at 10:11 PM, Wolfram Sang wrote: > > > >> > ctx->dev is probably the wrong device here. The i2c controller is not > >> > DMA capable itself, you need to have a pointer to the device that > >> > actually > >> > perfor

Re: [PATCH 4/6] i2c: busses: add SLIMpro I2C device driver on APM X-Gene platform

2015-02-02 Thread Feng Kan
On Thu, Jan 29, 2015 at 10:11 PM, Wolfram Sang wrote: > >> > ctx->dev is probably the wrong device here. The i2c controller is not >> > DMA capable itself, you need to have a pointer to the device that actually >> > performs the DMA here. >> >> Arnd, I do agree this may not be the best identificat

Re: [PATCH 4/6] i2c: busses: add SLIMpro I2C device driver on APM X-Gene platform

2015-01-29 Thread Wolfram Sang
> > ctx->dev is probably the wrong device here. The i2c controller is not > > DMA capable itself, you need to have a pointer to the device that actually > > performs the DMA here. > > Arnd, I do agree this may not be the best identification. There is no > representation for this on the Linux side

Re: [PATCH 4/6] i2c: busses: add SLIMpro I2C device driver on APM X-Gene platform

2015-01-29 Thread Feng Kan
On Tue, Nov 11, 2014 at 1:51 PM, Arnd Bergmann wrote: > On Tuesday 07 October 2014 17:06:47 Feng Kan wrote: >> diff --git a/drivers/i2c/busses/Kconfig b/drivers/i2c/busses/Kconfig >> index 2e45ae3..a03042c 100644 >> --- a/drivers/i2c/busses/Kconfig >> +++ b/drivers/i2c/busses/Kconfig >> @@ -1009,6

Re: [PATCH 4/6] i2c: busses: add SLIMpro I2C device driver on APM X-Gene platform

2015-01-09 Thread Wolfram Sang
> > I guess this is a driver for embedded? If so, please sort it properly. > Sorry, having let this dangle for a while. I will fix up comments and submit > another version. I can move this to embedded, however Xgene is > suppose to be a server class chip. Then simply leave it as is :) signat

Re: [PATCH 4/6] i2c: busses: add SLIMpro I2C device driver on APM X-Gene platform

2015-01-09 Thread Arnd Bergmann
On Friday 09 January 2015 10:56:51 Feng Kan wrote: > On Tue, Nov 11, 2014 at 1:51 PM, Arnd Bergmann wrote: > > On Tuesday 07 October 2014 17:06:47 Feng Kan wrote: > >> diff --git a/drivers/i2c/busses/Kconfig b/drivers/i2c/busses/Kconfig > >> index 2e45ae3..a03042c 100644 > >> --- a/drivers/i2c/bus

Re: [PATCH 4/6] i2c: busses: add SLIMpro I2C device driver on APM X-Gene platform

2015-01-09 Thread Feng Kan
On Tue, Nov 11, 2014 at 1:51 PM, Arnd Bergmann wrote: > On Tuesday 07 October 2014 17:06:47 Feng Kan wrote: >> diff --git a/drivers/i2c/busses/Kconfig b/drivers/i2c/busses/Kconfig >> index 2e45ae3..a03042c 100644 >> --- a/drivers/i2c/busses/Kconfig >> +++ b/drivers/i2c/busses/Kconfig >> @@ -1009,6

Re: [PATCH 4/6] i2c: busses: add SLIMpro I2C device driver on APM X-Gene platform

2015-01-09 Thread Feng Kan
On Tue, Nov 11, 2014 at 12:32 PM, Wolfram Sang wrote: > On Tue, Oct 07, 2014 at 05:06:47PM -0700, Feng Kan wrote: >> Add SLIMpro I2C device driver on APM X-Gene platform. This I2C >> device driver use the SLIMpro Mailbox driver to tunnel message to >> the SLIMpro coprocessor to do the work of acce

Re: [PATCH 4/6] i2c: busses: add SLIMpro I2C device driver on APM X-Gene platform

2014-11-17 Thread Feng Kan
On Tue, Nov 11, 2014 at 12:32 PM, Wolfram Sang wrote: > On Tue, Oct 07, 2014 at 05:06:47PM -0700, Feng Kan wrote: >> Add SLIMpro I2C device driver on APM X-Gene platform. This I2C >> device driver use the SLIMpro Mailbox driver to tunnel message to >> the SLIMpro coprocessor to do the work of acce

Re: [PATCH 4/6] i2c: busses: add SLIMpro I2C device driver on APM X-Gene platform

2014-11-11 Thread Arnd Bergmann
On Tuesday 07 October 2014 17:06:47 Feng Kan wrote: > diff --git a/drivers/i2c/busses/Kconfig b/drivers/i2c/busses/Kconfig > index 2e45ae3..a03042c 100644 > --- a/drivers/i2c/busses/Kconfig > +++ b/drivers/i2c/busses/Kconfig > @@ -1009,6 +1009,15 @@ config I2C_CROS_EC_TUNNEL > connected the

Re: [PATCH 4/6] i2c: busses: add SLIMpro I2C device driver on APM X-Gene platform

2014-11-11 Thread Wolfram Sang
On Tue, Oct 07, 2014 at 05:06:47PM -0700, Feng Kan wrote: > Add SLIMpro I2C device driver on APM X-Gene platform. This I2C > device driver use the SLIMpro Mailbox driver to tunnel message to > the SLIMpro coprocessor to do the work of accessing I2C components. > > Signed-off-by: Feng Kan > Signed

[PATCH 4/6] i2c: busses: add SLIMpro I2C device driver on APM X-Gene platform

2014-10-07 Thread Feng Kan
Add SLIMpro I2C device driver on APM X-Gene platform. This I2C device driver use the SLIMpro Mailbox driver to tunnel message to the SLIMpro coprocessor to do the work of accessing I2C components. Signed-off-by: Feng Kan Signed-off-by: Hieu Le --- drivers/i2c/busses/Kconfig | 9 +