Re: [PATCH 4/6] mfd: Add support for the MediaTek MT6358 PMIC

2019-02-08 Thread Matthias Kaehlcke
Hi, A few comments inline. On a general note I agree with others that this code would benefit from more comments. On Wed, Jan 30, 2019 at 05:18:09PM +0800, Hsin-Hsiung Wang wrote: > This adds support for the MediaTek MT6358 PMIC. This is a > multifunction device with the following sub modules: >

Re: [PATCH 4/6] mfd: Add support for the MediaTek MT6358 PMIC

2019-02-07 Thread Mark Brown
On Thu, Feb 07, 2019 at 10:04:50AM +, Marc Zyngier wrote: > On 07/02/2019 09:34, Lee Jones wrote: > >> +static struct irq_top_t mt6358_ints[] = { > >> + MT6358_TOP_GEN(BUCK), > >> + MT6358_TOP_GEN(LDO), > >> + MT6358_TOP_GEN(PSC), > >> + MT6358_TOP_GEN(SCK), > >> + MT6358_TOP_GEN(BM), > >

Re: [PATCH 4/6] mfd: Add support for the MediaTek MT6358 PMIC

2019-02-07 Thread Marc Zyngier
Hi Lee, On 07/02/2019 09:34, Lee Jones wrote: > Thomas, et al., > > Please could you take a look at this? > > I need some IRQ related guidance. TIA. > > On Wed, 30 Jan 2019, Hsin-Hsiung Wang wrote: > >> This adds support for the MediaTek MT6358 PMIC. This is a >> multifunction device with the

Re: [PATCH 4/6] mfd: Add support for the MediaTek MT6358 PMIC

2019-02-07 Thread Lee Jones
Thomas, et al., Please could you take a look at this? I need some IRQ related guidance. TIA. On Wed, 30 Jan 2019, Hsin-Hsiung Wang wrote: > This adds support for the MediaTek MT6358 PMIC. This is a > multifunction device with the following sub modules: > > - Regulator > - RTC > - Codec > - In

Re: [PATCH 4/6] mfd: Add support for the MediaTek MT6358 PMIC

2019-01-31 Thread Lee Jones
On Thu, 31 Jan 2019, Pi-Hsun Shih wrote: > On Wed, Jan 30, 2019 at 5:19 PM Hsin-Hsiung Wang > wrote: > > > > This adds support for the MediaTek MT6358 PMIC. This is a > > multifunction device with the following sub modules: > > > > - Regulator > > - RTC > > - Codec > > - Interrupt > > > > It is i

Re: [PATCH 4/6] mfd: Add support for the MediaTek MT6358 PMIC

2019-01-31 Thread Hsin-hsiung Wang
Hi Pi-Hsun, On Thu, 2019-01-31 at 11:56 +0800, Pi-Hsun Shih wrote: > On Wed, Jan 30, 2019 at 5:19 PM Hsin-Hsiung Wang > wrote: > > > > This adds support for the MediaTek MT6358 PMIC. This is a > > multifunction device with the following sub modules: > > > > - Regulator > > - RTC > > - Codec > > -

Re: [PATCH 4/6] mfd: Add support for the MediaTek MT6358 PMIC

2019-01-30 Thread Pi-Hsun Shih
On Wed, Jan 30, 2019 at 5:19 PM Hsin-Hsiung Wang wrote: > > This adds support for the MediaTek MT6358 PMIC. This is a > multifunction device with the following sub modules: > > - Regulator > - RTC > - Codec > - Interrupt > > It is interfaced to the host controller using SPI interface > by a propri

[PATCH 4/6] mfd: Add support for the MediaTek MT6358 PMIC

2019-01-30 Thread Hsin-Hsiung Wang
This adds support for the MediaTek MT6358 PMIC. This is a multifunction device with the following sub modules: - Regulator - RTC - Codec - Interrupt It is interfaced to the host controller using SPI interface by a proprietary hardware called PMIC wrapper or pwrap. MT6358 MFD is a child device of