Re: [PATCH 4/6] mm, oom: skip over vforked tasks

2016-05-30 Thread Michal Hocko
So I've ended up with a replacement for this patch which does the following: --- >From c40900923c78b51215794cc445d3f5a589b8f785 Mon Sep 17 00:00:00 2001 From: Michal Hocko Date: Mon, 30 May 2016 13:53:28 +0200 Subject: [PATCH] mm, oom: skip vforked tasks from being selected vforked tasks are not

Re: [PATCH 4/6] mm, oom: skip over vforked tasks

2016-05-30 Thread Michal Hocko
On Mon 30-05-16 13:40:17, Vladimir Davydov wrote: > On Mon, May 30, 2016 at 11:52:12AM +0200, Michal Hocko wrote: > > On Mon 30-05-16 09:13:57, Michal Hocko wrote: > > > On Fri 27-05-16 19:48:30, Vladimir Davydov wrote: > > > > On Thu, May 26, 2016 at 02:40:13PM +0200, Michal Hocko wrote: > > > [..

Re: [PATCH 4/6] mm, oom: skip over vforked tasks

2016-05-30 Thread Vladimir Davydov
On Mon, May 30, 2016 at 11:52:12AM +0200, Michal Hocko wrote: > On Mon 30-05-16 09:13:57, Michal Hocko wrote: > > On Fri 27-05-16 19:48:30, Vladimir Davydov wrote: > > > On Thu, May 26, 2016 at 02:40:13PM +0200, Michal Hocko wrote: > > [...] > > > > @@ -839,6 +841,13 @@ void oom_kill_process(struct

Re: [PATCH 4/6] mm, oom: skip over vforked tasks

2016-05-30 Thread Michal Hocko
On Mon 30-05-16 09:13:57, Michal Hocko wrote: > On Fri 27-05-16 19:48:30, Vladimir Davydov wrote: > > On Thu, May 26, 2016 at 02:40:13PM +0200, Michal Hocko wrote: > [...] > > > @@ -839,6 +841,13 @@ void oom_kill_process(struct oom_control *oc, struct > > > task_struct *p, > > > for_each_process

Re: [PATCH 4/6] mm, oom: skip over vforked tasks

2016-05-30 Thread Michal Hocko
On Fri 27-05-16 19:48:30, Vladimir Davydov wrote: > On Thu, May 26, 2016 at 02:40:13PM +0200, Michal Hocko wrote: [...] > > @@ -839,6 +841,13 @@ void oom_kill_process(struct oom_control *oc, struct > > task_struct *p, > > for_each_process(p) { > > if (!process_shares_mm(p, mm)) > >

Re: [PATCH 4/6] mm, oom: skip over vforked tasks

2016-05-27 Thread Vladimir Davydov
On Thu, May 26, 2016 at 02:40:13PM +0200, Michal Hocko wrote: > From: Michal Hocko > > vforked tasks are not really sitting on memory so it doesn't matter much > to kill them. Parents are waiting for vforked task killable so it is > better to chose parent which is the real mm owner. Teach oom_bad

[PATCH 4/6] mm, oom: skip over vforked tasks

2016-05-26 Thread Michal Hocko
From: Michal Hocko vforked tasks are not really sitting on memory so it doesn't matter much to kill them. Parents are waiting for vforked task killable so it is better to chose parent which is the real mm owner. Teach oom_badness to ignore all tasks which haven't passed mm_release. oom_kill_proce