Re: [PATCH 4/6] mm cma: rename PF_MEMALLOC_NOCMA to PF_MEMALLOC_NOMOVABLE

2020-12-03 Thread Pavel Tatashin
> > Reviewed-by: John Hubbard Thank you for your review. Pasha

Re: [PATCH 4/6] mm cma: rename PF_MEMALLOC_NOCMA to PF_MEMALLOC_NOMOVABLE

2020-12-03 Thread Pavel Tatashin
On Thu, Dec 3, 2020 at 3:57 AM Michal Hocko wrote: > > On Wed 02-12-20 00:23:28, Pavel Tatashin wrote: > > PF_MEMALLOC_NOCMA is used for longterm pinning and has an effect of > > clearing _GFP_MOVABLE or prohibiting allocations from ZONE_MOVABLE. > > This is not precise. You are mixing the impleme

Re: [PATCH 4/6] mm cma: rename PF_MEMALLOC_NOCMA to PF_MEMALLOC_NOMOVABLE

2020-12-03 Thread Michal Hocko
On Wed 02-12-20 00:23:28, Pavel Tatashin wrote: > PF_MEMALLOC_NOCMA is used for longterm pinning and has an effect of > clearing _GFP_MOVABLE or prohibiting allocations from ZONE_MOVABLE. This is not precise. You are mixing the implementation and the intention here. I would say "PF_MEMALLOC_NOCMA

Re: [PATCH 4/6] mm cma: rename PF_MEMALLOC_NOCMA to PF_MEMALLOC_NOMOVABLE

2020-12-03 Thread John Hubbard
On 12/1/20 9:23 PM, Pavel Tatashin wrote: PF_MEMALLOC_NOCMA is used for longterm pinning and has an effect of clearing _GFP_MOVABLE or prohibiting allocations from ZONE_MOVABLE. We will prohibit allocating any pages that are getting longterm pinned from ZONE_MOVABLE, and we would want to unify a

[PATCH 4/6] mm cma: rename PF_MEMALLOC_NOCMA to PF_MEMALLOC_NOMOVABLE

2020-12-01 Thread Pavel Tatashin
PF_MEMALLOC_NOCMA is used for longterm pinning and has an effect of clearing _GFP_MOVABLE or prohibiting allocations from ZONE_MOVABLE. We will prohibit allocating any pages that are getting longterm pinned from ZONE_MOVABLE, and we would want to unify and re-use this flag. So, rename it to generi