Re: [PATCH 4/6] of: add API for changing parameters of fixed link

2015-03-31 Thread Stas Sergeev
30.03.2015 19:06, Florian Fainelli пишет: > 2015-03-30 7:39 GMT-07:00 Stas Sergeev : >> 27.03.2015 20:15, Florian Fainelli пишет: >>> I think your concerns are valid, but I don't think there is going to be >>> any problem with the approach I suggested because there is a contract >>> that the fixed

Re: [PATCH 4/6] of: add API for changing parameters of fixed link

2015-03-30 Thread Stas Sergeev
30.03.2015 19:06, Florian Fainelli пишет: > So yes, it is a bug in the sense that it is not transparently handled, > but at the same time, the PHY library has no way to know whether a > fixed_link_update callback is being invoked since it is not poking > into the fixed PHY driver. Maybe then it wou

Re: [PATCH 4/6] of: add API for changing parameters of fixed link

2015-03-30 Thread Florian Fainelli
2015-03-30 7:39 GMT-07:00 Stas Sergeev : > 27.03.2015 20:15, Florian Fainelli пишет: >> I think your concerns are valid, but I don't think there is going to be >> any problem with the approach I suggested because there is a contract >> that the fixed PHYs and regular PHYs need to > Hello Florian. >

Re: [PATCH 4/6] of: add API for changing parameters of fixed link

2015-03-30 Thread Stas Sergeev
27.03.2015 20:15, Florian Fainelli пишет: > I think your concerns are valid, but I don't think there is going to be > any problem with the approach I suggested because there is a contract > that the fixed PHYs and regular PHYs need to Hello Florian. As promised, today I tried to resurrect my first

Re: [PATCH 4/6] of: add API for changing parameters of fixed link

2015-03-27 Thread Stas Sergeev
27.03.2015 20:15, Florian Fainelli пишет: > On 27/03/15 09:39, Stas Sergeev wrote: >> 27.03.2015 19:21, Florian Fainelli пишет: Do you want mvneta to register a similar callback in of_mdio, instead of adding an explicit state-updating functions? Something like of_phy_fixed_link_set_u

Re: [PATCH 4/6] of: add API for changing parameters of fixed link

2015-03-27 Thread Florian Fainelli
On 27/03/15 09:39, Stas Sergeev wrote: > 27.03.2015 19:21, Florian Fainelli пишет: >>> Do you want mvneta to register a similar callback in of_mdio, instead >>> of adding an explicit state-updating functions? Something like >>> of_phy_fixed_link_set_update_callback()? >> You don't need an of_phy_fi

Re: [PATCH 4/6] of: add API for changing parameters of fixed link

2015-03-27 Thread Stas Sergeev
27.03.2015 19:21, Florian Fainelli пишет: >> Do you want mvneta to register a similar callback in of_mdio, instead >> of adding an explicit state-updating functions? Something like >> of_phy_fixed_link_set_update_callback()? > You don't need an of_phy_fixed_link_set_update callback, you just need >

Re: [PATCH 4/6] of: add API for changing parameters of fixed link

2015-03-27 Thread Florian Fainelli
2015-03-27 9:07 GMT-07:00 Stas Sergeev : > 27.03.2015 18:41, Florian Fainelli пишет: >> 2015-03-27 6:37 GMT-07:00 Stas Sergeev : >>> >>> The following API is added: >>> - of_phy_fixed_link_set_link() allows to set link state (up/down) >>> - of_phy_fixed_link_set_speed() allows to set link speed >>>

Re: [PATCH 4/6] of: add API for changing parameters of fixed link

2015-03-27 Thread Stas Sergeev
27.03.2015 18:41, Florian Fainelli пишет: > 2015-03-27 6:37 GMT-07:00 Stas Sergeev : >> >> The following API is added: >> - of_phy_fixed_link_set_link() allows to set link state (up/down) >> - of_phy_fixed_link_set_speed() allows to set link speed >> - of_phy_fixed_link_set_duplex() allows to enabl

Re: [PATCH 4/6] of: add API for changing parameters of fixed link

2015-03-27 Thread Florian Fainelli
2015-03-27 6:37 GMT-07:00 Stas Sergeev : > > The following API is added: > - of_phy_fixed_link_set_link() allows to set link state (up/down) > - of_phy_fixed_link_set_speed() allows to set link speed > - of_phy_fixed_link_set_duplex() allows to enable/disable duplex > > This API is needed when the

[PATCH 4/6] of: add API for changing parameters of fixed link

2015-03-27 Thread Stas Sergeev
The following API is added: - of_phy_fixed_link_set_link() allows to set link state (up/down) - of_phy_fixed_link_set_speed() allows to set link speed - of_phy_fixed_link_set_duplex() allows to enable/disable duplex This API is needed when the MDIO-less link have some other means of a status pass