Re: [PATCH 4/6] regulator: gpio-regulator: use devm_regulator_register()

2013-12-08 Thread Jingoo Han
On Friday, December 06, 2013 9:09 PM, Mark Brown wrote: > On Fri, Dec 06, 2013 at 10:12:05AM +0100, Heiko Stübner wrote: > > > I'm not this firm in the core driver/device behaviour, but when looking at > > __device_release_driver I see that the remove callback runs before > > devres_release_all, w

Re: [PATCH 4/6] regulator: gpio-regulator: use devm_regulator_register()

2013-12-06 Thread Mark Brown
On Fri, Dec 06, 2013 at 10:12:05AM +0100, Heiko Stübner wrote: > I'm not this firm in the core driver/device behaviour, but when looking at > __device_release_driver I see that the remove callback runs before > devres_release_all, which would effectively free the gpios before the > regulator ge

Re: [PATCH 4/6] regulator: gpio-regulator: use devm_regulator_register()

2013-12-06 Thread Heiko Stübner
Hi, Am Freitag, 6. Dezember 2013, 08:10:42 schrieb Jingoo Han: > @@ -351,8 +352,6 @@ static int gpio_regulator_remove(struct platform_device > *pdev) { > struct gpio_regulator_data *drvdata = platform_get_drvdata(pdev); > > - regulator_unregister(drvdata->dev); > - > gpio_free_ar

[PATCH 4/6] regulator: gpio-regulator: use devm_regulator_register()

2013-12-05 Thread Jingoo Han
Use devm_regulator_register() to make cleanup paths simpler. Signed-off-by: Jingoo Han --- drivers/regulator/gpio-regulator.c |5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/regulator/gpio-regulator.c b/drivers/regulator/gpio-regulator.c index 13ec94d..fb4120