Re: [PATCH 4/6] sched/fair: reorder newidle_balance pulled_task test

2021-02-09 Thread Dietmar Eggemann
On 05/02/2021 12:48, Vincent Guittot wrote: > Reorder the tests and skip prevent useless test when no load balance has > been performed. LGTM. But IMHO the reason why those two if conditions can be skipped for the 'goto out' path is that we don't release the rq lock rather the actual lb. Might

[PATCH 4/6] sched/fair: reorder newidle_balance pulled_task test

2021-02-05 Thread Vincent Guittot
Reorder the tests and skip prevent useless test when no load balance has been performed. Signed-off-by: Vincent Guittot --- kernel/sched/fair.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/kernel/sched/fair.c b/kernel/sched/fair.c index