Re: [PATCH 4/6] solos-pci: fix error return code

2014-11-23 Thread David Miller
From: Julia Lawall Date: Sat, 22 Nov 2014 15:39:17 +0100 > From: Julia Lawall > > Return a negative error code on failure. > > A simplified version of the semantic match that finds this problem is as > follows: (http://coccinelle.lip6.fr/) ... > Signed-off-by: Julia Lawall Applied, thanks

Re: [PATCH 4/6] solos-pci: fix error return code

2014-11-23 Thread David Miller
From: Julia Lawall julia.law...@lip6.fr Date: Sat, 22 Nov 2014 15:39:17 +0100 From: Julia Lawall julia.law...@lip6.fr Return a negative error code on failure. A simplified version of the semantic match that finds this problem is as follows: (http://coccinelle.lip6.fr/) ...

[PATCH 4/6] solos-pci: fix error return code

2014-11-22 Thread Julia Lawall
From: Julia Lawall Return a negative error code on failure. A simplified version of the semantic match that finds this problem is as follows: (http://coccinelle.lip6.fr/) // @@ identifier ret; expression e1,e2; @@ ( if (\(ret < 0\|ret != 0\)) { ... return ret; } | ret = 0 ) ... when != ret =

[PATCH 4/6] solos-pci: fix error return code

2014-11-22 Thread Julia Lawall
From: Julia Lawall julia.law...@lip6.fr Return a negative error code on failure. A simplified version of the semantic match that finds this problem is as follows: (http://coccinelle.lip6.fr/) // smpl @@ identifier ret; expression e1,e2; @@ ( if (\(ret 0\|ret != 0\)) { ... return ret; } | ret