Re: [PATCH 4/6] trace: Replace seq_printf by simpler equivalents

2014-11-05 Thread Joe Perches
On Wed, 2014-11-05 at 19:38 -0500, Steven Rostedt wrote: > On Wed, 05 Nov 2014 14:51:48 -0800 Joe Perches wrote: [] > > > I know that it's considered bad form > > > to split strings like this, but I consider this one of the exceptions > > > to the rule. > > > > Why is that? > > > > btw: when th

Re: [PATCH 4/6] trace: Replace seq_printf by simpler equivalents

2014-11-05 Thread Steven Rostedt
On Wed, 05 Nov 2014 14:51:48 -0800 Joe Perches wrote: > On Wed, 2014-11-05 at 17:34 -0500, Steven Rostedt wrote: > > On Fri, 12 Sep 2014 11:25:52 +0200 Rasmus Villemoes > > wrote: > > > Using seq_printf to print a simple string or a single character is a > > > lot more expensive than it needs t

Re: [PATCH 4/6] trace: Replace seq_printf by simpler equivalents

2014-11-05 Thread Steven Rostedt
On Wed, 05 Nov 2014 23:44:17 +0100 Rasmus Villemoes wrote: > On Wed, Nov 05 2014, Steven Rostedt wrote: > > > On Fri, 12 Sep 2014 11:25:52 +0200 > > Rasmus Villemoes wrote: > > > >> diff --git a/kernel/trace/ftrace.c b/kernel/trace/ftrace.c > >> index 5916a8e..7b9ce28 100644 > >> --- a/kernel/

Re: [PATCH 4/6] trace: Replace seq_printf by simpler equivalents

2014-11-05 Thread Joe Perches
On Wed, 2014-11-05 at 17:34 -0500, Steven Rostedt wrote: > On Fri, 12 Sep 2014 11:25:52 +0200 Rasmus Villemoes > wrote: > > Using seq_printf to print a simple string or a single character is a > > lot more expensive than it needs to be, since seq_puts and seq_putc > > exist. [] > > diff --git a/k

Re: [PATCH 4/6] trace: Replace seq_printf by simpler equivalents

2014-11-05 Thread Rasmus Villemoes
On Wed, Nov 05 2014, Steven Rostedt wrote: > On Fri, 12 Sep 2014 11:25:52 +0200 > Rasmus Villemoes wrote: > >> diff --git a/kernel/trace/ftrace.c b/kernel/trace/ftrace.c >> index 5916a8e..7b9ce28 100644 >> --- a/kernel/trace/ftrace.c >> +++ b/kernel/trace/ftrace.c >> @@ -556,13 +556,13 @@ static

Re: [PATCH 4/6] trace: Replace seq_printf by simpler equivalents

2014-11-05 Thread Steven Rostedt
On Fri, 12 Sep 2014 11:25:52 +0200 Rasmus Villemoes wrote: > Using seq_printf to print a simple string or a single character is a > lot more expensive than it needs to be, since seq_puts and seq_putc > exist. > > These patches do > > seq_printf(m, s) -> seq_puts(m, s) > seq_printf(m, "%s",

[PATCH 4/6] trace: Replace seq_printf by simpler equivalents

2014-09-12 Thread Rasmus Villemoes
Using seq_printf to print a simple string or a single character is a lot more expensive than it needs to be, since seq_puts and seq_putc exist. These patches do seq_printf(m, s) -> seq_puts(m, s) seq_printf(m, "%s", s) -> seq_puts(m, s) seq_printf(m, "%c", c) -> seq_putc(m, c) Subsequent p