Re: [PATCH 4/7] ARM: dts: Enable N950 keyboard sleep leds by default

2016-04-12 Thread Tony Lindgren
* Pavel Machek [160401 23:48]: > > Sounds like the thing to do is to just configure the I2C LED > > controller in the dts file if we don't already have that. And > > assuming it has a Linux driver. > > I don't see what you mean here. If you want to always keep the debug > leds

Re: [PATCH 4/7] ARM: dts: Enable N950 keyboard sleep leds by default

2016-04-12 Thread Tony Lindgren
* Pavel Machek [160401 23:48]: > > Sounds like the thing to do is to just configure the I2C LED > > controller in the dts file if we don't already have that. And > > assuming it has a Linux driver. > > I don't see what you mean here. If you want to always keep the debug > leds on... that may be

Re: [PATCH 4/7] ARM: dts: Enable N950 keyboard sleep leds by default

2016-04-02 Thread Pavel Machek
Hi! > > > The two LEDs this GPIO controls are hardwired to sys_clkreq and > > > sys_off_mode pins that are the control signals between the SoC > > > and PMIC. > > > > No, not on N900. On N900, these LEDs are normally used for keyboard > > backlight. > > Oh I see. I've totally forgotten that as

Re: [PATCH 4/7] ARM: dts: Enable N950 keyboard sleep leds by default

2016-04-02 Thread Pavel Machek
Hi! > > > The two LEDs this GPIO controls are hardwired to sys_clkreq and > > > sys_off_mode pins that are the control signals between the SoC > > > and PMIC. > > > > No, not on N900. On N900, these LEDs are normally used for keyboard > > backlight. > > Oh I see. I've totally forgotten that as

Re: [PATCH 4/7] ARM: dts: Enable N950 keyboard sleep leds by default

2016-04-01 Thread Tony Lindgren
* Pavel Machek [160401 05:46]: > Hi! > > > > On Tue, Mar 29, 2016 at 12:51:28PM +0200, Pavel Machek wrote: > > > > For 1-3 in the series, Acked-by: Pavel Machek > > > > > > > > > Like the Nokia N900, the N950 has leds to show > > > > > the state of sys_clkreq and

Re: [PATCH 4/7] ARM: dts: Enable N950 keyboard sleep leds by default

2016-04-01 Thread Tony Lindgren
* Pavel Machek [160401 05:46]: > Hi! > > > > On Tue, Mar 29, 2016 at 12:51:28PM +0200, Pavel Machek wrote: > > > > For 1-3 in the series, Acked-by: Pavel Machek > > > > > > > > > Like the Nokia N900, the N950 has leds to show > > > > > the state of sys_clkreq and sys_off_mode pins. > > > > >

Re: [PATCH 4/7] ARM: dts: Enable N950 keyboard sleep leds by default

2016-04-01 Thread Pavel Machek
Hi! > > On Tue, Mar 29, 2016 at 12:51:28PM +0200, Pavel Machek wrote: > > > For 1-3 in the series, Acked-by: Pavel Machek > > > > > > > Like the Nokia N900, the N950 has leds to show > > > > the state of sys_clkreq and sys_off_mode pins. > > > > > > > > A detailed description for

Re: [PATCH 4/7] ARM: dts: Enable N950 keyboard sleep leds by default

2016-04-01 Thread Pavel Machek
Hi! > > On Tue, Mar 29, 2016 at 12:51:28PM +0200, Pavel Machek wrote: > > > For 1-3 in the series, Acked-by: Pavel Machek > > > > > > > Like the Nokia N900, the N950 has leds to show > > > > the state of sys_clkreq and sys_off_mode pins. > > > > > > > > A detailed description for the LEDs and

Re: [PATCH 4/7] ARM: dts: Enable N950 keyboard sleep leds by default

2016-03-30 Thread Sebastian Reichel
Hi, On Wed, Mar 30, 2016 at 12:35:21PM -0700, Tony Lindgren wrote: > > > I must say I've seen it on N900, and yes, it is useful, but no, I > > > don't think this is right. > > > > > > This is not a LED. This is a interface that changes meaning of two > > > other LEDs. I guess it should go to

Re: [PATCH 4/7] ARM: dts: Enable N950 keyboard sleep leds by default

2016-03-30 Thread Sebastian Reichel
Hi, On Wed, Mar 30, 2016 at 12:35:21PM -0700, Tony Lindgren wrote: > > > I must say I've seen it on N900, and yes, it is useful, but no, I > > > don't think this is right. > > > > > > This is not a LED. This is a interface that changes meaning of two > > > other LEDs. I guess it should go to

Re: [PATCH 4/7] ARM: dts: Enable N950 keyboard sleep leds by default

2016-03-30 Thread Tony Lindgren
* Sebastian Reichel [160329 07:53]: > Hi, > > On Tue, Mar 29, 2016 at 12:51:28PM +0200, Pavel Machek wrote: > > For 1-3 in the series, Acked-by: Pavel Machek > > > > > Like the Nokia N900, the N950 has leds to show > > > the state of sys_clkreq and sys_off_mode

Re: [PATCH 4/7] ARM: dts: Enable N950 keyboard sleep leds by default

2016-03-30 Thread Tony Lindgren
* Sebastian Reichel [160329 07:53]: > Hi, > > On Tue, Mar 29, 2016 at 12:51:28PM +0200, Pavel Machek wrote: > > For 1-3 in the series, Acked-by: Pavel Machek > > > > > Like the Nokia N900, the N950 has leds to show > > > the state of sys_clkreq and sys_off_mode pins. > > > > > > A detailed

Re: [PATCH 4/7] ARM: dts: Enable N950 keyboard sleep leds by default

2016-03-29 Thread Pavel Machek
On Tue 2016-03-29 16:52:09, Sebastian Reichel wrote: > Hi, > > On Tue, Mar 29, 2016 at 12:51:28PM +0200, Pavel Machek wrote: > > For 1-3 in the series, Acked-by: Pavel Machek > > > > > Like the Nokia N900, the N950 has leds to show > > > the state of sys_clkreq and sys_off_mode

Re: [PATCH 4/7] ARM: dts: Enable N950 keyboard sleep leds by default

2016-03-29 Thread Pavel Machek
On Tue 2016-03-29 16:52:09, Sebastian Reichel wrote: > Hi, > > On Tue, Mar 29, 2016 at 12:51:28PM +0200, Pavel Machek wrote: > > For 1-3 in the series, Acked-by: Pavel Machek > > > > > Like the Nokia N900, the N950 has leds to show > > > the state of sys_clkreq and sys_off_mode pins. > > > > >

Re: [PATCH 4/7] ARM: dts: Enable N950 keyboard sleep leds by default

2016-03-29 Thread Sebastian Reichel
Hi, On Tue, Mar 29, 2016 at 12:51:28PM +0200, Pavel Machek wrote: > For 1-3 in the series, Acked-by: Pavel Machek > > > Like the Nokia N900, the N950 has leds to show > > the state of sys_clkreq and sys_off_mode pins. > > > > A detailed description for the LEDs and > > OMAP's

Re: [PATCH 4/7] ARM: dts: Enable N950 keyboard sleep leds by default

2016-03-29 Thread Sebastian Reichel
Hi, On Tue, Mar 29, 2016 at 12:51:28PM +0200, Pavel Machek wrote: > For 1-3 in the series, Acked-by: Pavel Machek > > > Like the Nokia N900, the N950 has leds to show > > the state of sys_clkreq and sys_off_mode pins. > > > > A detailed description for the LEDs and > > OMAP's sleep states can

Re: [PATCH 4/7] ARM: dts: Enable N950 keyboard sleep leds by default

2016-03-29 Thread Pavel Machek
Hi! For 1-3 in the series, Acked-by: Pavel Machek > Like the Nokia N900, the N950 has leds to show > the state of sys_clkreq and sys_off_mode pins. > > A detailed description for the LEDs and > OMAP's sleep states can be found in Tony's > commit for the Nokia N900: > >

Re: [PATCH 4/7] ARM: dts: Enable N950 keyboard sleep leds by default

2016-03-29 Thread Pavel Machek
Hi! For 1-3 in the series, Acked-by: Pavel Machek > Like the Nokia N900, the N950 has leds to show > the state of sys_clkreq and sys_off_mode pins. > > A detailed description for the LEDs and > OMAP's sleep states can be found in Tony's > commit for the Nokia N900: > >

[PATCH 4/7] ARM: dts: Enable N950 keyboard sleep leds by default

2016-03-12 Thread Sebastian Reichel
Like the Nokia N900, the N950 has leds to show the state of sys_clkreq and sys_off_mode pins. A detailed description for the LEDs and OMAP's sleep states can be found in Tony's commit for the Nokia N900: c1be2032f66df9e1238bd5bc4ca666de88a62abc Signed-off-by: Sebastian Reichel

[PATCH 4/7] ARM: dts: Enable N950 keyboard sleep leds by default

2016-03-12 Thread Sebastian Reichel
Like the Nokia N900, the N950 has leds to show the state of sys_clkreq and sys_off_mode pins. A detailed description for the LEDs and OMAP's sleep states can be found in Tony's commit for the Nokia N900: c1be2032f66df9e1238bd5bc4ca666de88a62abc Signed-off-by: Sebastian Reichel ---