Re: [PATCH 4/7] atmel-isi: fix IS_ERR_VALUE usage

2016-02-21 Thread Guennadi Liakhovetski
Hi Andrzej, On Mon, 15 Feb 2016, Andrzej Hajda wrote: > IS_ERR_VALUE macro should be used only with unsigned long type. > For signed types comparison 'ret < 0' should be used. > > The patch follows conclusion from discussion on LKML [1][2]. > > [1]:

Re: [PATCH 4/7] atmel-isi: fix IS_ERR_VALUE usage

2016-02-21 Thread Guennadi Liakhovetski
Hi Andrzej, On Mon, 15 Feb 2016, Andrzej Hajda wrote: > IS_ERR_VALUE macro should be used only with unsigned long type. > For signed types comparison 'ret < 0' should be used. > > The patch follows conclusion from discussion on LKML [1][2]. > > [1]:

Re: [PATCH 4/7] atmel-isi: fix IS_ERR_VALUE usage

2016-02-16 Thread Al Viro
On Mon, Feb 15, 2016 at 03:35:22PM +0100, Andrzej Hajda wrote: > IS_ERR_VALUE macro should be used only with unsigned long type. > For signed types comparison 'ret < 0' should be used. > > The patch follows conclusion from discussion on LKML [1][2]. ACK

Re: [PATCH 4/7] atmel-isi: fix IS_ERR_VALUE usage

2016-02-16 Thread Al Viro
On Mon, Feb 15, 2016 at 03:35:22PM +0100, Andrzej Hajda wrote: > IS_ERR_VALUE macro should be used only with unsigned long type. > For signed types comparison 'ret < 0' should be used. > > The patch follows conclusion from discussion on LKML [1][2]. ACK

[PATCH 4/7] atmel-isi: fix IS_ERR_VALUE usage

2016-02-15 Thread Andrzej Hajda
IS_ERR_VALUE macro should be used only with unsigned long type. For signed types comparison 'ret < 0' should be used. The patch follows conclusion from discussion on LKML [1][2]. [1]: http://permalink.gmane.org/gmane.linux.kernel/2120927 [2]: http://permalink.gmane.org/gmane.linux.kernel/2150581

[PATCH 4/7] atmel-isi: fix IS_ERR_VALUE usage

2016-02-15 Thread Andrzej Hajda
IS_ERR_VALUE macro should be used only with unsigned long type. For signed types comparison 'ret < 0' should be used. The patch follows conclusion from discussion on LKML [1][2]. [1]: http://permalink.gmane.org/gmane.linux.kernel/2120927 [2]: http://permalink.gmane.org/gmane.linux.kernel/2150581