Re: [PATCH 4/7] cgroup_freezer: don't stall transition to FROZEN for PF_NOFREEZE or PF_FREEZER_SKIP tasks

2012-10-24 Thread Tejun Heo
Hello, Oleg. On Tue, Oct 23, 2012 at 05:55:33PM +0200, Oleg Nesterov wrote: > > Ooh, ouch, definitely. We should clear that. Can you please make a > > patch? > > Sure... but what do you think is better? > > I'd prefer to simply clear PF_NOFREEZE (without set_freezable), but > obviously this do

Re: [PATCH 4/7] cgroup_freezer: don't stall transition to FROZEN for PF_NOFREEZE or PF_FREEZER_SKIP tasks

2012-10-23 Thread Oleg Nesterov
On 10/22, Tejun Heo wrote: > > On Mon, Oct 22, 2012 at 08:34:53PM +0200, Oleg Nesterov wrote: > > > > Hmm. We seem to "leak" PF_NOFREEZE if a kernel thread execs? > > Perhaps do_execve_common() should do set_freezable() before return. > > > > Or, at least, simply clear this flag along with PF_KTHRE

Re: [PATCH 4/7] cgroup_freezer: don't stall transition to FROZEN for PF_NOFREEZE or PF_FREEZER_SKIP tasks

2012-10-22 Thread Tejun Heo
Hey, On Mon, Oct 22, 2012 at 08:34:53PM +0200, Oleg Nesterov wrote: > On 10/16, Tejun Heo wrote: > > > > cgroup_freezer doesn't transition from FREEZING to FROZEN if the > > cgroup contains PF_NOFREEZE tasks or tasks sleeping with > > PF_FREEZER_SKIP set. > > And thus the patch looks like another

Re: [PATCH 4/7] cgroup_freezer: don't stall transition to FROZEN for PF_NOFREEZE or PF_FREEZER_SKIP tasks

2012-10-22 Thread Oleg Nesterov
On 10/16, Tejun Heo wrote: > > cgroup_freezer doesn't transition from FREEZING to FROZEN if the > cgroup contains PF_NOFREEZE tasks or tasks sleeping with > PF_FREEZER_SKIP set. And thus the patch looks like another bugfix to me. Just one question, and this question is offtopic again, > Only ke

[PATCH 4/7] cgroup_freezer: don't stall transition to FROZEN for PF_NOFREEZE or PF_FREEZER_SKIP tasks

2012-10-16 Thread Tejun Heo
cgroup_freezer doesn't transition from FREEZING to FROZEN if the cgroup contains PF_NOFREEZE tasks or tasks sleeping with PF_FREEZER_SKIP set. Only kernel tasks can be non-freezable (PF_NOFREEZE) and there's nothing cgroup_freezer or userland can do about or to it. It's pointless to stall the tra