Re: [PATCH 4/7] exec: Move bprm_mm_init into alloc_bprm

2020-07-14 Thread Christoph Hellwig
On Tue, Jul 14, 2020 at 08:30:02AM -0500, Eric W. Biederman wrote: > > Currently it is necessary for the usermode helper code and the code that > launches init to use set_fs so that pages coming from the kernel look like > they are coming from userspace. > > To allow that usage of set_fs to be re

Re: [PATCH 4/7] exec: Move bprm_mm_init into alloc_bprm

2020-07-14 Thread Kees Cook
On Tue, Jul 14, 2020 at 08:30:02AM -0500, Eric W. Biederman wrote: > > Currently it is necessary for the usermode helper code and the code that > launches init to use set_fs so that pages coming from the kernel look like > they are coming from userspace. > > To allow that usage of set_fs to be re

[PATCH 4/7] exec: Move bprm_mm_init into alloc_bprm

2020-07-14 Thread Eric W. Biederman
Currently it is necessary for the usermode helper code and the code that launches init to use set_fs so that pages coming from the kernel look like they are coming from userspace. To allow that usage of set_fs to be removed cleanly the argument copying from userspace needs to happen earlier. Mo