Re: [PATCH 4/7] mm, vmscan: show LRU name in mm_vmscan_lru_isolate tracepoint

2017-01-05 Thread Michal Hocko
On Thu 05-01-17 14:56:23, Mel Gorman wrote: > On Thu, Jan 05, 2017 at 11:16:13AM +0100, Michal Hocko wrote: > > > > diff --git a/include/trace/events/vmscan.h > > > > b/include/trace/events/vmscan.h > > > > index 36c999f806bf..7ec59e0432c4 100644 > > > > --- a/include/trace/events/vmscan.h > > > >

Re: [PATCH 4/7] mm, vmscan: show LRU name in mm_vmscan_lru_isolate tracepoint

2017-01-05 Thread Mel Gorman
On Thu, Jan 05, 2017 at 11:16:13AM +0100, Michal Hocko wrote: > > > diff --git a/include/trace/events/vmscan.h b/include/trace/events/vmscan.h > > > index 36c999f806bf..7ec59e0432c4 100644 > > > --- a/include/trace/events/vmscan.h > > > +++ b/include/trace/events/vmscan.h > > > @@ -277,9 +277,9 @@

Re: [PATCH 4/7] mm, vmscan: show LRU name in mm_vmscan_lru_isolate tracepoint

2017-01-05 Thread Michal Hocko
On Thu 05-01-17 15:04:58, Minchan Kim wrote: > On Wed, Jan 04, 2017 at 11:19:39AM +0100, Michal Hocko wrote: > > From: Michal Hocko > > > > mm_vmscan_lru_isolate currently prints only whether the LRU we isolate > > from is file or anonymous but we do not know which LRU this is. > > > > It is use

Re: [PATCH 4/7] mm, vmscan: show LRU name in mm_vmscan_lru_isolate tracepoint

2017-01-04 Thread Minchan Kim
On Wed, Jan 04, 2017 at 11:19:39AM +0100, Michal Hocko wrote: > From: Michal Hocko > > mm_vmscan_lru_isolate currently prints only whether the LRU we isolate > from is file or anonymous but we do not know which LRU this is. > > It is useful to know whether the list is active or inactive, since w

[PATCH 4/7] mm, vmscan: show LRU name in mm_vmscan_lru_isolate tracepoint

2017-01-04 Thread Michal Hocko
From: Michal Hocko mm_vmscan_lru_isolate currently prints only whether the LRU we isolate from is file or anonymous but we do not know which LRU this is. It is useful to know whether the list is active or inactive, since we are using the same function to isolate pages from both of them and it's

Re: [PATCH 4/7] mm, vmscan: show LRU name in mm_vmscan_lru_isolate tracepoint

2017-01-03 Thread Michal Hocko
On Tue 03-01-17 21:52:44, Michal Hocko wrote: > On Tue 03-01-17 21:47:45, Michal Hocko wrote: > > On Tue 03-01-17 18:08:58, Vlastimil Babka wrote: > > > On 12/28/2016 04:30 PM, Michal Hocko wrote: > > > > From: Michal Hocko > > > > > > > > mm_vmscan_lru_isolate currently prints only whether the L

Re: [PATCH 4/7] mm, vmscan: show LRU name in mm_vmscan_lru_isolate tracepoint

2017-01-03 Thread Michal Hocko
On Tue 03-01-17 22:40:23, Vlastimil Babka wrote: > On 01/03/2017 10:24 PM, Michal Hocko wrote: [...] > > > So the tool should be OK as long as it can find values for LRU_* > > > constants. Is this what is the problem? > > Exactly. So this should make it work (it compiles it has to be correct, rig

Re: [PATCH 4/7] mm, vmscan: show LRU name in mm_vmscan_lru_isolate tracepoint

2017-01-03 Thread Vlastimil Babka
On 01/03/2017 10:24 PM, Michal Hocko wrote: On Tue 03-01-17 21:52:44, Michal Hocko wrote: On Tue 03-01-17 21:47:45, Michal Hocko wrote: > On Tue 03-01-17 18:08:58, Vlastimil Babka wrote: > > On 12/28/2016 04:30 PM, Michal Hocko wrote: > > > From: Michal Hocko > > > > > > mm_vmscan_lru_isolate c

Re: [PATCH 4/7] mm, vmscan: show LRU name in mm_vmscan_lru_isolate tracepoint

2017-01-03 Thread Michal Hocko
On Tue 03-01-17 21:47:45, Michal Hocko wrote: > On Tue 03-01-17 18:08:58, Vlastimil Babka wrote: > > On 12/28/2016 04:30 PM, Michal Hocko wrote: > > > From: Michal Hocko > > > > > > mm_vmscan_lru_isolate currently prints only whether the LRU we isolate > > > from is file or anonymous but we do no

Re: [PATCH 4/7] mm, vmscan: show LRU name in mm_vmscan_lru_isolate tracepoint

2017-01-03 Thread Michal Hocko
On Tue 03-01-17 18:08:58, Vlastimil Babka wrote: > On 12/28/2016 04:30 PM, Michal Hocko wrote: > > From: Michal Hocko > > > > mm_vmscan_lru_isolate currently prints only whether the LRU we isolate > > from is file or anonymous but we do not know which LRU this is. It is > > useful to know whether

Re: [PATCH 4/7] mm, vmscan: show LRU name in mm_vmscan_lru_isolate tracepoint

2017-01-03 Thread Vlastimil Babka
On 12/28/2016 04:30 PM, Michal Hocko wrote: From: Michal Hocko mm_vmscan_lru_isolate currently prints only whether the LRU we isolate from is file or anonymous but we do not know which LRU this is. It is useful to know whether the list is file or anonymous as well. Change the tracepoint to show

Re: [PATCH 4/7] mm, vmscan: show LRU name in mm_vmscan_lru_isolate tracepoint

2016-12-30 Thread Michal Hocko
On Fri 30-12-16 10:56:25, Minchan Kim wrote: > On Thu, Dec 29, 2016 at 08:56:49AM +0100, Michal Hocko wrote: > > On Thu 29-12-16 15:02:04, Minchan Kim wrote: > > > On Wed, Dec 28, 2016 at 04:30:29PM +0100, Michal Hocko wrote: > > > > From: Michal Hocko > > > > > > > > mm_vmscan_lru_isolate curren

Re: [PATCH 4/7] mm, vmscan: show LRU name in mm_vmscan_lru_isolate tracepoint

2016-12-29 Thread Minchan Kim
On Thu, Dec 29, 2016 at 08:56:49AM +0100, Michal Hocko wrote: > On Thu 29-12-16 15:02:04, Minchan Kim wrote: > > On Wed, Dec 28, 2016 at 04:30:29PM +0100, Michal Hocko wrote: > > > From: Michal Hocko > > > > > > mm_vmscan_lru_isolate currently prints only whether the LRU we isolate > > > from is

Re: [PATCH 4/7] mm, vmscan: show LRU name in mm_vmscan_lru_isolate tracepoint

2016-12-29 Thread Hillf Danton
On Wednesday, December 28, 2016 11:30 PM Michal Hocko wrote: > From: Michal Hocko > > mm_vmscan_lru_isolate currently prints only whether the LRU we isolate > from is file or anonymous but we do not know which LRU this is. It is > useful to know whether the list is file or anonymous as well. Ch

Re: [PATCH 4/7] mm, vmscan: show LRU name in mm_vmscan_lru_isolate tracepoint

2016-12-28 Thread Michal Hocko
On Thu 29-12-16 15:02:04, Minchan Kim wrote: > On Wed, Dec 28, 2016 at 04:30:29PM +0100, Michal Hocko wrote: > > From: Michal Hocko > > > > mm_vmscan_lru_isolate currently prints only whether the LRU we isolate > > from is file or anonymous but we do not know which LRU this is. It is > > useful t

Re: [PATCH 4/7] mm, vmscan: show LRU name in mm_vmscan_lru_isolate tracepoint

2016-12-28 Thread Minchan Kim
On Wed, Dec 28, 2016 at 04:30:29PM +0100, Michal Hocko wrote: > From: Michal Hocko > > mm_vmscan_lru_isolate currently prints only whether the LRU we isolate > from is file or anonymous but we do not know which LRU this is. It is > useful to know whether the list is file or anonymous as well. Cha

Re: [PATCH 4/7] mm, vmscan: show LRU name in mm_vmscan_lru_isolate tracepoint

2016-12-28 Thread Michal Hocko
On Wed 28-12-16 18:40:16, Nikolay Borisov wrote: [...] > " > It is useful to know whether the list is active or inactive, since we > are using the same function to isolate pages from both of them and it's > hard to distinguish otherwise. > " OK, updated. Thanks! -- Michal Hocko SUSE Labs

Re: [PATCH 4/7] mm, vmscan: show LRU name in mm_vmscan_lru_isolate tracepoint

2016-12-28 Thread Nikolay Borisov
On 28.12.2016 18:00, Michal Hocko wrote: > On Wed 28-12-16 17:50:31, Nikolay Borisov wrote: >> >> >> On 28.12.2016 17:30, Michal Hocko wrote: >>> From: Michal Hocko >>> >>> mm_vmscan_lru_isolate currently prints only whether the LRU we isolate >>> from is file or anonymous but we do not know whi

Re: [PATCH 4/7] mm, vmscan: show LRU name in mm_vmscan_lru_isolate tracepoint

2016-12-28 Thread Michal Hocko
On Wed 28-12-16 17:50:31, Nikolay Borisov wrote: > > > On 28.12.2016 17:30, Michal Hocko wrote: > > From: Michal Hocko > > > > mm_vmscan_lru_isolate currently prints only whether the LRU we isolate > > from is file or anonymous but we do not know which LRU this is. It is > > useful to know whet

Re: [PATCH 4/7] mm, vmscan: show LRU name in mm_vmscan_lru_isolate tracepoint

2016-12-28 Thread Nikolay Borisov
On 28.12.2016 17:30, Michal Hocko wrote: > From: Michal Hocko > > mm_vmscan_lru_isolate currently prints only whether the LRU we isolate > from is file or anonymous but we do not know which LRU this is. It is > useful to know whether the list is file or anonymous as well. Change Maybe you wante

[PATCH 4/7] mm, vmscan: show LRU name in mm_vmscan_lru_isolate tracepoint

2016-12-28 Thread Michal Hocko
From: Michal Hocko mm_vmscan_lru_isolate currently prints only whether the LRU we isolate from is file or anonymous but we do not know which LRU this is. It is useful to know whether the list is file or anonymous as well. Change the tracepoint to show symbolic names of the lru rather. Signed-off