Re: [PATCH 4/7] sysfs: simplify sysfs_remove_dir()

2007-07-31 Thread Tejun Heo
Cornelia Huck wrote: > On Tue, 31 Jul 2007 19:15:08 +0900, > Tejun Heo <[EMAIL PROTECTED]> wrote: > >> With the shadow directories gone, sysfs_remove_dir() can be simplified. >> >> * parent doesn't need to be grabbed separately. Just access >> old_dentry->d_parent. >> >> * parent sd can never c

Re: [PATCH 4/7] sysfs: simplify sysfs_remove_dir()

2007-07-31 Thread Cornelia Huck
On Tue, 31 Jul 2007 19:15:08 +0900, Tejun Heo <[EMAIL PROTECTED]> wrote: > With the shadow directories gone, sysfs_remove_dir() can be simplified. > > * parent doesn't need to be grabbed separately. Just access > old_dentry->d_parent. > > * parent sd can never change. Remove code to move und

[PATCH 4/7] sysfs: simplify sysfs_remove_dir()

2007-07-31 Thread Tejun Heo
With the shadow directories gone, sysfs_remove_dir() can be simplified. * parent doesn't need to be grabbed separately. Just access old_dentry->d_parent. * parent sd can never change. Remove code to move under the new parent. * Massage comments a bit. Signed-off-by: Tejun Heo <[EMAIL PROT